Load the library (and its dependencies) from its path rather than potentially the applications#4
Open
ramon-juicelabs wants to merge 1 commit intomaster-juicefrom
Open
Conversation
ramon-juicelabs
requested review from
canadacow,
charles-juicelabs,
dave-juicelabs and
ykagan
and removed request for
canadacow,
charles-juicelabs,
dave-juicelabs and
ykagan
…entially the applications When loading the ICD its dependencies will use the standard search path which uses the applications path first which means the incorrect (or even malicious) modules could be loaded. This change restricts it by using the modules path. This will fall back to the original logic when paths are not absolute.
ramon-juicelabs
force-pushed
the
vulkan-loader-load-absolute
branch
from
18c0461 to
a043f74
Compare
dave-juicelabs
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading the ICD its dependencies will use the standard search path which uses the applications path first which means the incorrect (or even malicious) modules could be loaded. This change restricts it by using the modules path. This will fall back to the original logic which may be problematic but left for compatibility.