Skip to content

Reduce prominence of GitHub CTA and improve login page hierarchy#46

Merged
JuergGood merged 1 commit intomasterfrom
cleanup-3
Mar 11, 2026
Merged

Reduce prominence of GitHub CTA and improve login page hierarchy#46
JuergGood merged 1 commit intomasterfrom
cleanup-3

Conversation

@JuergGood
Copy link
Owner

  • Removed GitHub CTA from brand logo, repositioned to footer in login page.
  • accessibility.
  • Added acceptance confirmation to task documentation for verification.

UX / UI Change PR

Scope

  • Dark mode
  • Mobile layout
  • Tables/logs/admin views
  • Tasks/list layouts
  • Other:

Acceptance criteria (must be explicit)

What changed (systemic first)

  • Tokens/theme:
  • Shared components/styles:
  • Component-specific changes (only if necessary):

Screens / viewports verified

  • Mobile 375×667 light
  • Mobile 375×667 dark
  • Desktop 1440×900 light
  • Desktop 1440×900 dark

UX Regression Checklist (must all be ✅)

Theme & contrast

  • Action icons visible in dark mode (incl. mat-icon-button + destructive actions)
  • Menus/dialogs/selects have readable contrast in dark mode
  • Focus ring visible (keyboard navigation)

Mobile space & layout

  • Header density acceptable (content above the fold on 375×667)
  • No unintended horizontal scrolling on mobile

Responsive patterns

  • Tables on mobile: cards or usable scroll (no clipped headers)
  • Toolbars/filters don’t create orphan controls / accidental wraps
  • Titles don’t break mid-word; truncation/wrapping intentional

Maintainability

  • No new hardcoded hex colors (unless added to tokens)
  • No new !important (or justified below)

Justifications (required if any)

  • New !important added because:
  • Component-specific workaround added because:

- Removed GitHub CTA from brand logo, repositioned to footer in login page.
- accessibility.
- Added acceptance confirmation to task documentation for verification.
@JuergGood JuergGood merged commit e56860b into master Mar 11, 2026
1 of 8 checks passed
@JuergGood JuergGood deleted the cleanup-3 branch March 11, 2026 19:02
JuergGood added a commit that referenced this pull request Mar 11, 2026
Reduce prominence of GitHub CTA and improve login page hierarchy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant