Check for login before pulling from cache, resolving fatal errors#93
Open
jrgp wants to merge 1 commit intoJorgenPhi:masterfrom
jrgp:cacheerrorfix
Open
Check for login before pulling from cache, resolving fatal errors#93jrgp wants to merge 1 commit intoJorgenPhi:masterfrom jrgp:cacheerrorfix
jrgp wants to merge 1 commit intoJorgenPhi:masterfrom
jrgp:cacheerrorfix
Conversation
Currently, if login fails and you try getSnaps() or any of the other get functions, it will call getUpdates() which calls $this->cache->get() before checking for a valid login. As $this->cache is not populated until a valid login, this will cause this sort of error: Fatal error: Call to a member function get() on a non-object in /homepages/15/d419114431/htdocs/bobink/snapchat/src/snapchat.php on line 234 This change modifies the code to perform the login check before pulling from cache, solving the fatal errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if login fails and you try getSnaps() or any of the
other get functions, it will call getUpdates() which calls
$this->cache->get() before checking for a valid login.
As $this->cache is not populated until a valid login, this will
cause this sort of error:
Fatal error: Call to a member function get() on a non-object in /homepages/15/d419114431/htdocs/bobink/snapchat/src/snapchat.php on line 234This change modifies the code to perform the login check before
pulling from cache, solving the fatal errors.