Fix cache error checking#37
Open
gabrielsoldani wants to merge 2 commits intoJorgenPhi:masterfrom
gabrielsoldani:fix-cache-error-checking
Open
Fix cache error checking#37gabrielsoldani wants to merge 2 commits intoJorgenPhi:masterfrom gabrielsoldani:fix-cache-error-checking
gabrielsoldani wants to merge 2 commits intoJorgenPhi:masterfrom
gabrielsoldani:fix-cache-error-checking
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a condition to check if the Snapchat::$cache object is set before using it. If it is not set, it issues the request normally and does not cache the response, if successful.
The second commit adds a check before setting the cache as well. The request should not normally complete successfully when $cache is not set, but in the future you might want to add the option to not to set the cache object in the constructor/login so requests are never cached, and this would be necessary.