Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f8078ccf2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "**/*.mts" | ||
| ], | ||
| "exclude": ["node_modules"] | ||
| "exclude": ["node_modules", "prisma/migrations", "tests", "**/*.test.ts", "**/*.test.tsx", "**/*spec.ts", "**/*spec.tsx"] |
There was a problem hiding this comment.
The new exclusion patterns use **/*spec.ts and **/*spec.tsx, which only match filenames ending in spec.ts/spec.tsx without a preceding dot. Common test filenames like foo.spec.ts and foo.spec.tsx will still be included in the TypeScript program, so the intended “exclude tests” change won’t apply to those files and can leave test type errors in the build. If the goal is to exclude .spec.* tests, the glob should be **/*.spec.ts and **/*.spec.tsx.
Useful? React with 👍 / 👎.
1 participant
No description provided.