Allow saving whole session with all workspaces by cedryc · Pull Request #104 · JonnyHaystack/i3-resurrect

cedryc · 2021-06-06T14:51:24Z

Work in progress

Made a pull request for this feature:

i3-resurrect save/restore --session to save whole session
i3-resurrect save/restore --workspace list-of-workspaces for saving multiples workspaces
i3-resurrect restore --session --clear for deleting active workspaces before restoring.

This implementation use subdir for saving profiles instead of files, to allow saving multiples workspaces or whole session profile

this may be usefull for some people

JonnyHaystack

I reviewed some of this and have left some comments, but it's really a lot so it's pretty hard. Appreciate your work though. If you can keep the changes especially to the interface as minimal as possible then that would make things easier.

JonnyHaystack · 2021-07-23T10:04:10Z

i3_resurrect/main.py

 from . import util

-DEFAULT_DIRECTORY = config.get('directory', '~/.i3/i3-resurrect/')
+DEFAULT_DIRECTORY = config.get('directory', '~/.config/i3-resurrect/')


Why did you change this?

Ya it's not relevant here, so removed.

JonnyHaystack · 2021-07-23T10:05:55Z

i3_resurrect/layout.py

-    for window_id in window_ids:
-        xdo_unmap_window(window_id)
+    if target in ('clean', 'force'):
+        keept_windows = clean_workspace(layout, saved_programs, normal_windows, target)


Don't understand this variable name. What is keept?

That represent windows that are preserved on the layout. Changed variable name to preserved_windows.

JonnyHaystack · 2021-07-23T10:10:04Z

i3_resurrect/layout.py

+    keept_windows = []
+    saved_windows = treeutils.get_leaves(layout)
+    for saved_program in saved_programs:
+        # print(saved_window)


This line needs to be removed

JonnyHaystack · 2021-07-23T10:28:12Z

i3_resurrect/util.py

    directory = Path(expandvars(directory)).expanduser()
    if profile is not None:
-        directory = directory / 'profiles'
+        directory = directory / profile


Why did you change this? That's not how the directory structure is

Yes is a personal preference, that was easier for me to implement the feature with profiles stored in dirs.This way, the directory name is the name of the profile. Also allow saving multiple workspace in the same profile name. So session profiles can be handled the same way as session without profile name.

JonnyHaystack · 2021-07-23T10:33:17Z

i3_resurrect/main.py

    """
    List saved workspaces or profiles.
    """
+    # TODO: list workspaces in profiles


This is something that worked before. Please don't break existing functionality in a PR.

Fixed in PR update

JonnyHaystack · 2021-07-23T11:46:53Z

README.md

  --layout-only              Only restore layout.
  --programs-only            Only restore running programs.
+  -c, --clean                Move program that are not part of the workspace
+                             layout to               the scratchpad.


Cool idea 😄

JonnyHaystack · 2021-07-23T11:47:24Z

README.md

+                             layout to               the scratchpad.

+  -F, --force                Close program that are not part of the workspace
+                             layout               before restore it.


I notice both of these help texts have a big space in the middle because of how you've written them in the code, so you'll need to fix that.

JonnyHaystack · 2021-07-23T13:47:13Z

i3_resurrect/main.py

+    Save i3 workspace(s) layout(s) or whole session and running programs to a file.
+
+    WORKSPACES are the workspaces to save.
+    [default: current workspace]


What's up with this comment?

JonnyHaystack · 2021-07-23T13:48:35Z

i3_resurrect/main.py

 @click.option('--workspace', '-w',
-              help='The workspace to save.\n[default: current workspace]')
+              is_flag=True,
+              help='The workspaces to save.\n This can either be a name or the number of a workspace.')


Why are you making this a flag?

To allow saving multiples workspaces at once. Workspaces name or number are parsed as arguments

JonnyHaystack · 2021-07-23T13:57:52Z

i3_resurrect/main.py

 @click.option('--workspace', '-w',
-              help='The workspace to restore.\n[default: current workspace]')
+              is_flag=True,
+              help='The WORKSPACES to restore.\nThis can either be a name or the number of a workspace.')


Doesn't make sense that you're making this a flag but also claiming that it takes a list of workspaces which it doesn't...

Ya, changed the comment..

TheBlackArroVV · 2022-05-14T00:15:34Z

Would this feature be finished in the future?

cedryc · 2022-06-27T17:47:07Z

Would this feature be finished in the future?

I made some changes on this feature in my repo, may need some further testing...

Thaodan · 2023-11-06T23:29:00Z

When would the program to be ran to save the session? Is there a hook to hook into to be called before the session ends.
Same for restoring them.

cedryc marked this pull request as draft June 6, 2021 14:53

cedryc closed this Jun 6, 2021

cedryc changed the title ~~Master~~ Allow saving whole session with all workspaces #84 Jun 6, 2021

cedryc changed the title ~~Allow saving whole session with all workspaces #84~~ Allow saving whole session with all workspaces Jun 6, 2021

cedryc reopened this Jun 6, 2021

cedryc mentioned this pull request Jun 6, 2021

Allow saving whole session with all workspaces #84

Open

JonnyHaystack reviewed Jul 30, 2021

View reviewed changes

Save workspaces profiles in dirs

3855e1a

cedryc force-pushed the master branch from 9c700b6 to bac5256 Compare June 27, 2022 16:34

Cedric Leporcq added 6 commits June 27, 2022 19:18

Allow saving multiples workspaces in once

7e11a3a

Allow saving whole workspaces session

840bf08

Add --clean, --reload and --kill options in restore command

e6f7b2e

Add Kill command to delete workspaces or whole session.

da103b7

Update README

e800330

Add TIMEOUT variable in config to restore command

02e568f

cedryc force-pushed the master branch from bac5256 to 02e568f Compare June 27, 2022 17:38

Uh oh!

Conversation

cedryc commented Jun 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonnyHaystack left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheBlackArroVV commented May 14, 2022

Uh oh!

cedryc commented Jun 27, 2022

Uh oh!

Thaodan commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cedryc commented Jun 6, 2021 •

edited

Loading

Thaodan commented Nov 6, 2023 •

edited

Loading