This repository was archived by the owner on Sep 13, 2019. It is now read-only.
Ensure that the chef shutdown service is configurable#2
Open
JonathanSerafini wants to merge 2 commits intomasterfrom
Open
Ensure that the chef shutdown service is configurable#2JonathanSerafini wants to merge 2 commits intomasterfrom
JonathanSerafini wants to merge 2 commits intomasterfrom
Conversation
webframp
reviewed
Dec 22, 2016
| ;; | ||
| stop) | ||
| echo "***** Deleting node and client *****" | ||
| node_name="<%= @node_name %>" |
There was a problem hiding this comment.
Is this expected to be the value of the attribute?
webframp
reviewed
Dec 22, 2016
| cookbook_file '/etc/init.d/chef_lifecycle' do | ||
| template '/etc/init.d/chef_lifecycle' do | ||
| source 'shutdown/chef_lifecycle.erb' | ||
| mode '0750' |
There was a problem hiding this comment.
Does this need a variables parameter to pass node['cfn']['shutdown']['node_name'] to the template as node_name ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New attributes in attributes/cfn-shutdown.rb
Pull request to resolve issue in #1
@webframp @sandervanburken Would this change work for you ?