Skip to content

SugarDetectionUtility integration and re-work of input file type detection (enhanced SMILES file parsing)#16

Merged
JonasSchaub merged 4 commits intoproductionfrom
sdu-integration
Oct 1, 2025
Merged

SugarDetectionUtility integration and re-work of input file type detection (enhanced SMILES file parsing)#16
JonasSchaub merged 4 commits intoproductionfrom
sdu-integration

Conversation

@JonasSchaub
Copy link
Copy Markdown
Owner

fixes #15
Updates CDK to v 2.12-SNAPSHOT (to get the SDU)
Preparation for v 1.6

…g, and starting to add the MORTAR DynamicSMILESFileReader
…ation in CMD app; updated doc; switched CMD app input file format detection to purely file extension-based
@JonasSchaub JonasSchaub requested a review from Copilot October 1, 2025 14:56
@JonasSchaub JonasSchaub self-assigned this Oct 1, 2025
@JonasSchaub JonasSchaub added the enhancement New feature or request label Oct 1, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates the SugarDetectionUtility (SDU) from CDK v2.12-SNAPSHOT and reworks input file type detection with enhanced SMILES file parsing capabilities. The main purpose is to prepare for version 1.6 by incorporating advanced sugar detection and processing functionality while improving file format recognition.

Key changes include:

  • Addition of comprehensive SMILES file format detection and parsing capabilities
  • Integration of SugarDetectionUtility for advanced sugar detection and processing
  • Refactoring of test files to use proper CDK package structure
  • Enhancement of existing SugarRemovalUtility tests with new functionality

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Test SMILES files Added various test files with different formats for dynamic SMILES reading
SugarRemovalUtilityTest.java Updated package structure and added comprehensive sugar detection tests
SugarDetectionUtilityTest.java New comprehensive test suite for sugar detection functionality
DynamicSMILESFileReaderTest.java Test suite for enhanced SMILES file format detection
SMILESFormatMatcher.java Removed CDK book example class
DynamicSMILESFileReader.java New dynamic SMILES file reader with format detection
DynamicSMILESFileFormat.java Data structure for SMILES file format specification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JonasSchaub JonasSchaub merged commit 06d22fc into production Oct 1, 2025
4 of 5 checks passed
@JonasSchaub JonasSchaub deleted the sdu-integration branch October 1, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants