Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses code quality improvements identified in issue #14, focusing on test naming conventions, documentation clarity, code cleanup, and minor refinements to error messages and formatting.
Key changes:
- Standardized test method naming to follow Java conventions (camelCase starting with lowercase)
- Improved documentation and error messages for better clarity
- Removed commented-out code and unnecessary blank lines
- Introduced a constant for map load capacity multiplier to reduce magic numbers
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| FragmentFingerprinterTest.java | Renamed test methods to follow naming conventions, removed large block of commented-out code, added clarifying comment |
| ExampleUsageTest.java | Removed excessive blank lines and commented-out code, fixed typo in comment |
| FragmentFingerprinter.java | Introduced constant for map capacity multiplier, improved error messages, enhanced method documentation, fixed typos, changed method visibility |
| CountFingerprint.java | Fixed typos in comments and error messages, simplified conditional logic, added documentation warning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/CountFingerprint.java
Show resolved
Hide resolved
JonasSchaub
requested changes
Jan 6, 2026
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Show resolved
Hide resolved
src/test/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinterTest.java
Show resolved
Hide resolved
src/test/java/de/unijena/cheminf/fragment/fingerprint/ExampleUsageTest.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/FragmentFingerprinter.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/fragment/fingerprint/CountFingerprint.java
Outdated
Show resolved
Hide resolved
|
JonasSchaub
reviewed
Apr 9, 2026
Owner
JonasSchaub
left a comment
There was a problem hiding this comment.
minimal comments, rest looks good!
src/test/java/de/unijena/cheminf/fragment/fingerprint/ExampleUsageTest.java
Show resolved
Hide resolved
src/test/java/de/unijena/cheminf/fragment/fingerprint/ExampleUsageTest.java
Show resolved
Hide resolved
src/test/java/de/unijena/cheminf/fragment/fingerprint/ExampleUsageTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Merges changes from Copilot review in #9 (corresponding Issue: #14 ).
Mainly includes code quality improvements.