Open
Conversation
Adding Vault solution
justinleapline
suggested changes
Jul 16, 2019
justinleapline
left a comment
justinleapline
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Here are a couple of things I suggest to change.
| Solution: | ||
|
|
||
| ``` | ||
| var password = web3.eth.getStorageAt(instance, index);` |
There was a problem hiding this comment.
Since this tutorial is focused around Metamask, I don't think we need to reference other ways. May cause confusion.
Suggested change
| var password = web3.eth.getStorageAt(instance, index);` |
| ``` | ||
| var password = web3.eth.getStorageAt(instance, index);` | ||
| // For Metamask use callback function | ||
| web3.eth.getStorageAt(instance.address, 1, (err,res)=>{password=res}); |
There was a problem hiding this comment.
This may be an easier example.
Suggested change
| web3.eth.getStorageAt(instance.address, 1, (err,res)=>{password=res}); | |
| web3.eth.getStorageAt(contract.address, 1, function(error, result) {password = web3.toAscii(result)}) |
| We'll be able to finally see the key string to unlock the vault! | ||
|
|
||
| > "A very strong secret password :)" | ||
|
|
There was a problem hiding this comment.
Suggested change
| To unlock the vault finally, run the following command: | |
| `await contract.unlock(password)` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.