Merged
Conversation
Elbow arrows (elbowed: true) were rendered using roughjs rc.curve() which produces smooth Bézier curves. Now uses rc.path()/gen.path() with an SVG path of straight lines and small quadratic corners (radius 16px), matching the original Excalidraw rendering. - Port generateElbowArrowShape() from excalidraw to src/shared.ts - Add elbow check in renderLine() (PNG) and svgLine() (SVG) - Add visual regression fixture with L/Z/U elbow shapes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elbowed: true) were rendered as smooth curves instead of right-angle pathsgenerateElbowArrowShape()from original Excalidraw — uses straight lines with small quadratic corners (16px radius)rc.path()) and SVG (gen.path()) renderersTest plan