Skip to content

added functionality for 24/7-runtime in FilterOnePole.cpp and fixed a… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KarlZeilhofer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added functionality for 24/7-runtime in FilterOnePole.cpp and fixed a… #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3da5dc4
added functionality for 24/7-runtime in FilterOnePole.cpp and fixed a…
KarlZeilhofer Dec 9, 2015
bbccc4d
bugfix: division by zero on micros() overflow
KarlZeilhofer Dec 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions FilterOnePole.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,17 @@ void FilterOnePole::setFilter( FILTER_TYPE ft, float fc, float initialValue ) {
}

float FilterOnePole::input( float inVal ) {
long time = micros();
ElapsedUS = float(time - LastUS); // cast to float here, for math
long int time = micros();
long int ElapsedUS = time - LastUS; // stick to long int here, because of underflow with float on subtractions.
// (31+1 bits of long int compared to 23+1 bit of the mantissa of float)
LastUS = time; // update this now

// minimize the effect of an overflow of micros(), which happens every 70 Minutes.
if(ElapsedUS < 0)
{
ElapsedUS = 10; // do not set to zero!!! (division by zero)
}

// shift the data values
Ylast = Y;
X = inVal; // this is now the most recent input value
Expand Down