Open
Conversation
yuye-aws
commented
Oct 13, 2025
| } | ||
|
|
||
| def __init__(self, max_number_of_docs: int = -1): | ||
| def __init__(self, dataset_path: str = DEFAULT_DATASET_PATH, max_number_of_docs: int = -1): |
Collaborator
Author
There was a problem hiding this comment.
I'm adding this change to allow user to specify the directory path
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
yuye-aws
force-pushed
the
Feat/S3Example
branch
from
2de279d to
53c1c5d
Compare
yuye-aws
commented
Oct 13, 2025
| "chunk_embedding": { | ||
| "type": "knn_vector", | ||
| "dimension": model_dimensions, | ||
| "method": {"engine": "s3vector"}, |
Collaborator
Author
There was a problem hiding this comment.
This is where to specify the s3vector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an example on how to use the S3. The example is very similar to the dense exact search. To the best of my knowledge, S3 only support exact search now.
Since this PR is just adding an example, I'm not including any UTs and ITs.