Potential fix for code scanning alert no. 1: Workflow does not contain permissions#25
Merged
Johnaverse merged 1 commit intomainfrom Mar 5, 2026
Merged
Potential fix for code scanning alert no. 1: Workflow does not contain permissions#25Johnaverse merged 1 commit intomainfrom
Johnaverse merged 1 commit intomainfrom
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses a GitHub code scanning alert by explicitly declaring minimal GITHUB_TOKEN permissions for the test-and-analyze job in the Docker build workflow, aligning the workflow with least-privilege guidance.
Changes:
- Add an explicit job-level
permissionsblock fortest-and-analyze. - Restrict
test-and-analyzetocontents: read(sufficient foractions/checkoutand the job’s current steps).
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Johnaverse/chains-api/security/code-scanning/1
To fix this, we should explicitly declare minimal
GITHUB_TOKENpermissions for thetest-and-analyzejob. This job only needs to read the repository contents (foractions/checkout) and does not interact with PRs, issues, or packages. The SonarQube step uses its own token (SONAR_TOKEN), notGITHUB_TOKEN, so no extra GitHub scopes are required.The best minimal-change fix is to add a
permissionsblock underjobs.test-and-analyzewithcontents: read. We leave the existingpermissionsblock onbuild-docker-pushunchanged, since that job legitimately needspackages: writeto push Docker images. Concretely, in.github/workflows/docker-build.yml, after theruns-on: ubuntu-latestline (line 21) insidetest-and-analyze, insert:No additional imports, methods, or definitions are required, as this is a pure workflow-configuration change.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.