Skip to content

Lab 2 done#1

Open
JohnSteck9 wants to merge 2 commits intomasterfrom
lab_2
Open

Lab 2 done#1
JohnSteck9 wants to merge 2 commits intomasterfrom
lab_2

Conversation

@JohnSteck9
Copy link
Owner

@JohnSteck9 JohnSteck9 commented Oct 6, 2021

Created simple shop page

image
image

Flutter layout explorer
image
image

@JohnSteck9 JohnSteck9 self-assigned this Oct 6, 2021
@romanoprid romanoprid self-requested a review October 6, 2021 08:52
@redd4ford redd4ford self-requested a review October 6, 2021 08:54
Copy link
Collaborator

@romanoprid romanoprid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, I think you can merge it.

Copy link
Collaborator

@redd4ford redd4ford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! You might want to clean the code from comments, though.

Copy link

@igor-leshkevych igor-leshkevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnSteck9 code-wise everything is nice, good job. From the UI perspective, I recommend increasing top/bottom padding for "Women" label, and also adding some padding in the bottom of the screen (to increase space between bottom list items and bottom edge of the screen).

@@ -0,0 +1,6 @@
import 'package:flutter/material.dart';

const kTextColor = Color(0xFF535353);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend using custom prefixes/hungarian notation/etc. in Dart. Historically, it was invented to manage complexity on the projects, but right now the direction industry moves towards is "don't create complex code, and you won't need custom prefixes for your variables)

} No newline at end of file
}


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra spaces

),
];

String dummyText =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use const

});
}

List<Product> products = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants