Skip to content

Update dependencies and refactor duplicate code patterns #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update dependencies and refactor duplicate code patterns #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84e3212
Initial plan
Copilot Nov 10, 2025
728a4fb
Update dependencies and fix TypeScript 5.9 compatibility
Copilot Nov 10, 2025
58e66a6
Extract shared combobox logic and improve code quality
Copilot Nov 10, 2025
0278836
Fix Uint8Array handling and update to ox-standard with oxfmt
Copilot Nov 10, 2025
b445e65
Complete ox-standard setup with oxfmt config and VSCode settings
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .oxfmtrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": ["./node_modules/ox-standard/.oxfmtrc.json"]
}
1 change: 0 additions & 1 deletion .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"recommendations": [
"biomejs.biome",
"oxc.oxc-vscode",
"typescriptteam.native-preview"
]
Expand Down
3 changes: 0 additions & 3 deletions biome.json
View file
Open in desktop

This file was deleted.

217 changes: 125 additions & 92 deletions docker/mgba-docker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,127 +1,160 @@
#!/usr/bin/env tsx
import { execSync } from 'node:child_process'
import { execSync } from "node:child_process";

const composeFile = 'docker/docker-compose.yml'
const dockerfile = 'docker/Dockerfile'
const image = 'mgba-test-env:latest'
const remoteImage = 'ghcr.io/johndeved/bills-pc/mgba-test-env:latest'
const container = 'mgba-test-environment'
const composeFile = "docker/docker-compose.yml";
const dockerfile = "docker/Dockerfile";
const image = "mgba-test-env:latest";
const remoteImage = "ghcr.io/johndeved/bills-pc/mgba-test-env:latest";
const container = "mgba-test-environment";

function run(cmd: string, env?: NodeJS.ProcessEnv) {
try {
execSync(cmd, { stdio: 'inherit', env: env ? { ...process.env, ...env } : process.env })
execSync(cmd, {
stdio: "inherit",
env: env ? { ...process.env, ...env } : process.env,
});
} catch {
process.exit(1)
process.exit(1);
}
}

function printHelp() {
console.log('\n\x1b[1mPokémon Save Web: mGBA Docker CLI\x1b[0m\n')
console.log('Usage: tsx docker/mgba-docker.ts <command> [args] [--game emerald|quetzal]\n')
console.log('Commands:')
console.log(' \x1b[36mstart\x1b[0m Start the mGBA Docker container in the background')
console.log(' \x1b[36mstart:build\x1b[0m Build and start the container in the background')
console.log(' \x1b[36mrun\x1b[0m Start the container in the foreground (logs shown)')
console.log(' \x1b[36mrun:build\x1b[0m Build and start the container in the foreground')
console.log(' \x1b[36mstop\x1b[0m Stop the running container')
console.log(' \x1b[36mbuild\x1b[0m Build the Docker image locally')
console.log(' \x1b[36mpull\x1b[0m Pull the latest image from GitHub Container Registry')
console.log(' \x1b[36mstatus\x1b[0m Show container status')
console.log(' \x1b[36mlogs\x1b[0m Show container logs')
console.log(' \x1b[36mexec <cmd..>\x1b[0m Run a command inside the running container')
console.log(' \x1b[36mshell\x1b[0m Open a shell inside the running container')
console.log(' \x1b[36mhelp\x1b[0m Show this help message')
console.log('\nOptions:')
console.log(' --game emerald|quetzal Select which ROM/savestate to load (default: emerald)')
console.log('\nExamples:')
console.log(' tsx docker/mgba-docker.ts start --game quetzal')
console.log(' tsx docker/mgba-docker.ts exec ls /app/data --game emerald')
console.log(' tsx docker/mgba-docker.ts shell --game quetzal')
console.log('')
console.log("\n\x1b[1mPokémon Save Web: mGBA Docker CLI\x1b[0m\n");
console.log(
"Usage: tsx docker/mgba-docker.ts <command> [args] [--game emerald|quetzal]\n",
);
console.log("Commands:");
console.log(
" \x1b[36mstart\x1b[0m Start the mGBA Docker container in the background",
);
console.log(
" \x1b[36mstart:build\x1b[0m Build and start the container in the background",
);
console.log(
" \x1b[36mrun\x1b[0m Start the container in the foreground (logs shown)",
);
console.log(
" \x1b[36mrun:build\x1b[0m Build and start the container in the foreground",
);
console.log(" \x1b[36mstop\x1b[0m Stop the running container");
console.log(
" \x1b[36mbuild\x1b[0m Build the Docker image locally",
);
console.log(
" \x1b[36mpull\x1b[0m Pull the latest image from GitHub Container Registry",
);
console.log(" \x1b[36mstatus\x1b[0m Show container status");
console.log(" \x1b[36mlogs\x1b[0m Show container logs");
console.log(
" \x1b[36mexec <cmd..>\x1b[0m Run a command inside the running container",
);
console.log(
" \x1b[36mshell\x1b[0m Open a shell inside the running container",
);
console.log(" \x1b[36mhelp\x1b[0m Show this help message");
console.log("\nOptions:");
console.log(
" --game emerald|quetzal Select which ROM/savestate to load (default: emerald)",
);
console.log("\nExamples:");
console.log(" tsx docker/mgba-docker.ts start --game quetzal");
console.log(" tsx docker/mgba-docker.ts exec ls /app/data --game emerald");
console.log(" tsx docker/mgba-docker.ts shell --game quetzal");
console.log("");
}

const [cmd, ...args] = process.argv.slice(2)
let game: string | undefined
const filteredArgs = [...args]
const gameIdx = filteredArgs.indexOf('--game')
const [cmd, ...args] = process.argv.slice(2);
let game: string | undefined;
const filteredArgs = [...args];
const gameIdx = filteredArgs.indexOf("--game");
if (gameIdx !== -1 && filteredArgs[gameIdx + 1]) {
game = filteredArgs[gameIdx + 1]
filteredArgs.splice(gameIdx, 2)
game = filteredArgs[gameIdx + 1];
filteredArgs.splice(gameIdx, 2);
}

function withGameEnv(cmd: string): { cmd: string; env?: NodeJS.ProcessEnv } {
if (!game) return { cmd }
if (!game) return { cmd };
// For docker exec, inject -e GAME=... as a CLI flag
if (cmd.startsWith('docker exec')) {
const parts = cmd.split(' ')
parts.splice(2, 0, '-e', `GAME=${game}`)
return { cmd: parts.join(' ') }
if (cmd.startsWith("docker exec")) {
const parts = cmd.split(" ");
parts.splice(2, 0, "-e", `GAME=${game}`);
return { cmd: parts.join(" ") };
}
// For docker compose, set env in Node.js process
if (cmd.includes('docker compose')) {
return { cmd, env: { GAME: game } }
if (cmd.includes("docker compose")) {
return { cmd, env: { GAME: game } };
}
// Fallback: set env for other commands
return { cmd, env: { GAME: game } }
return { cmd, env: { GAME: game } };
}

switch (cmd) {
case 'start': {
const { cmd: c, env } = withGameEnv(`docker compose -f ${composeFile} up -d`)
run(c, env)
break
case "start": {
const { cmd: c, env } = withGameEnv(
`docker compose -f ${composeFile} up -d`,
);
run(c, env);
break;
}
case 'start:build': {
const { cmd: c, env } = withGameEnv(`docker compose -f ${composeFile} up -d --build`)
run(c, env)
break
case "start:build": {
const { cmd: c, env } = withGameEnv(
`docker compose -f ${composeFile} up -d --build`,
);
run(c, env);
break;
}
case 'run': {
const { cmd: c, env } = withGameEnv(`docker compose -f ${composeFile} up`)
run(c, env)
break
case "run": {
const { cmd: c, env } = withGameEnv(`docker compose -f ${composeFile} up`);
run(c, env);
break;
}
case 'run:build': {
const { cmd: c, env } = withGameEnv(`docker compose -f ${composeFile} up --build`)
run(c, env)
break
case "run:build": {
const { cmd: c, env } = withGameEnv(
`docker compose -f ${composeFile} up --build`,
);
run(c, env);
break;
}
case 'stop':
run(`docker compose -f ${composeFile} down`)
break
case 'build':
run(`docker build -f ${dockerfile} -t ${image} .`)
break
case 'pull':
run(`docker pull ${remoteImage}`)
break
case 'status':
run(`docker compose -f ${composeFile} ps`)
break
case 'logs':
run(`docker logs -f ${container}`)
break
case 'exec': {
case "stop":
run(`docker compose -f ${composeFile} down`);
break;
case "build":
run(`docker build -f ${dockerfile} -t ${image} .`);
break;
case "pull":
run(`docker pull ${remoteImage}`);
break;
case "status":
run(`docker compose -f ${composeFile} ps`);
break;
case "logs":
run(`docker logs -f ${container}`);
break;
case "exec": {
if (filteredArgs.length === 0) {
console.error('Usage: tsx docker/mgba-docker.ts exec <command> [--game emerald|quetzal]')
process.exit(1)
console.error(
"Usage: tsx docker/mgba-docker.ts exec <command> [--game emerald|quetzal]",
);
process.exit(1);
}
const { cmd: c, env } = withGameEnv(`docker exec -it ${container} ${filteredArgs.map(a => `'${a.replace(/'/g, "'\\''")}'`).join(' ')}`)
run(c, env)
break
const { cmd: c, env } = withGameEnv(
`docker exec -it ${container} ${filteredArgs.map((a) => `'${a.replace(/'/g, "'\\''")}'`).join(" ")}`,
);
run(c, env);
break;
}
case 'shell': {
const { cmd: c, env } = withGameEnv(`docker exec -it ${container} bash`)
run(c, env)
break
case "shell": {
const { cmd: c, env } = withGameEnv(`docker exec -it ${container} bash`);
run(c, env);
break;
}
case 'help':
case "help":
case undefined:
printHelp()
process.exit(0)
break
printHelp();
process.exit(0);
break;
default:
console.error(`Unknown command: ${cmd}\n`)
printHelp()
process.exit(1)
console.error(`Unknown command: ${cmd}\n`);
printHelp();
process.exit(1);
}
Loading