Debouncer class name conflicts with dedicated Debouncer libraries#3
Open
rcbadiale wants to merge 3 commits intoJohn-Lluch:masterfrom
Open
Debouncer class name conflicts with dedicated Debouncer libraries#3rcbadiale wants to merge 3 commits intoJohn-Lluch:masterfrom
rcbadiale wants to merge 3 commits intoJohn-Lluch:masterfrom
Conversation
Rename the de Debouncer class to EncoderDebouncer in order to avoid conflicts with dedicated debouncer libraries
Declaring that this is a fork and giving credit to the original developer.
This reverts commit 7bc78f6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2
Using the debouncer as class name inside this library causes conflicts when dedicated debouncer libraries are used on project.
Solution:
In order to close this issue, the class name Debouncer was changed to EncoderDebouncer avoiding conflicts with dedicated debouncer libraries