Improvements - Generate Itinerary Part 2 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de responseCache. Corrigido RecenterButton do MapsExpanded que não levava o usuário de volta a sua posição real e sim o jogando para o meio do nada.
…e de Favoritar Local de um Roteiro. Tela nova de favoritos devidamente testada e aprovada para várias situações.
…lean e moderna. Alteração da visualização do calendário em Criar Itinerário. Feita a tela de Controle de Gastos. A nova tela de Controle de Gastos foi testada e provada funcional.
…te feita pelo @FenixReloaded porém agora com uma UI mais moderna, colorida e amigável. Também foi integrado o Expo-Sharing permitindo assim compartilhar esse PDF do roteiro em diversos locais diferentes. Agora alterar o background na tela de Stats daquele itinerário deixa a imagem salva mesmo quando o usuário sair e voltar a aquela tela (persistência de imagem).
…assim a UX do usuário com novos parâmetros de visualização de valores.
…am oficialmente. Dialogs de confirmação de ações foram criados, melhorando assim a UX do usuário em casos de acidentes de navegação e usabilidade. Os itinerários agora são salvos caso tenham tido alguma modificação e sejam fechados da forma correta. Alterada a mensagem para quando não tivermos nenhum roteiro passado disponível. Criados os cards para aparecerem nos filtros.
…ercel para manter nossas APIs sempre live (no momento essa regra vale também ainda para testes e ambientes dev).
…m um erro de Network Request.
JoaoGW
added
documentation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR includes multiple improvements to the itinerary generation feature, including bug fixes, UX enhancements, API migrations, and new functionality. However, there is a critical issue with the complete deletion of package.json and package-lock.json files.
Key Changes
- Migration of API endpoints from local development (
SEU-IP-AQUI:3000) to production Vercel deployment - Added API key validation for weather API
- URL updates for visa check and Google Places API endpoints
Reviewed changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | CRITICAL: Entire file deleted - appears unintentional |
| package-lock.json | CRITICAL: Entire file deleted - will break dependency resolution |
| nextjs-api/pages/api/weather.ts | Added weather API key validation with proper error handling |
| expo-app/src/screens/Itinerary/ItineraryVisaCheck.tsx | Updated API endpoint from localhost to Vercel production URL |
| expo-app/src/screens/HomePage/Home.tsx | Updated Google Places API endpoint from localhost to Vercel production URL |
Files not reviewed (1)
- expo-app/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
expo-app/src/screens/AIChat/AIChat.tsx:31
- Unused import responseCache.
import { NetInfoContext } from "@contexts/NetInfo";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+15
| if (!weatherApi) { | ||
| console.error("WEATHER API key is not configured"); | ||
| return res.status(500).json({ error: "Weather API key not configured" }); | ||
| } |
There was a problem hiding this comment.
[nitpick] Good defensive programming: Adding validation to check if the WEATHER API key is configured before making the API call. However, consider using a more specific environment variable check (e.g., process.env.WEATHER_API_KEY) rather than just checking if weatherApi is truthy, as this could catch configuration issues earlier.
Comment on lines
+380
to
+383
| if (dayData && dayData.timeline) { | ||
| dayData.timeline = dayData.timeline.filter((_, i) => i !== index); | ||
| newState[selectedDayIndex] = dayData; | ||
| } |
There was a problem hiding this comment.
This guard always evaluates to true.
Suggested change
| if (dayData && dayData.timeline) { | |
| dayData.timeline = dayData.timeline.filter((_, i) => i !== index); | |
| newState[selectedDayIndex] = dayData; | |
| } | |
| dayData.timeline = dayData.timeline.filter((_, i) => i !== index); | |
| newState[selectedDayIndex] = dayData; |
Comment on lines
+1
to
+13
| import { | ||
| AlertDialog, | ||
| AlertDialogBackdrop, | ||
| AlertDialogBody, | ||
| AlertDialogContent, | ||
| AlertDialogHeader, | ||
| Button, | ||
| ButtonIcon, | ||
| ButtonText, | ||
| Text, | ||
| View, | ||
| Pressable | ||
| } from "@gluestack-ui/themed"; |
There was a problem hiding this comment.
Unused imports Button, ButtonIcon, ButtonText.
|
|
||
| import AsyncStorage from '@react-native-async-storage/async-storage'; | ||
|
|
||
| import { Expense, ExpensesByCategory, ExpenseCategory } from '../../@types/ExpenseControlTypes'; |
There was a problem hiding this comment.
Unused import ExpenseCategory.
Suggested change
| import { Expense, ExpensesByCategory, ExpenseCategory } from '../../@types/ExpenseControlTypes'; | |
| import { Expense, ExpensesByCategory } from '../../@types/ExpenseControlTypes'; |
Comment on lines
+72
to
+76
| const formatCoordinates = (coordinates: string) => { | ||
| const [lat, lng] = coordinates.split(',').map(coord => coord.trim()); | ||
| return `${parseFloat(lat).toFixed(4)}, ${parseFloat(lng).toFixed(4)}`; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Unused variable formatCoordinates.
Suggested change
| const formatCoordinates = (coordinates: string) => { | |
| const [lat, lng] = coordinates.split(',').map(coord => coord.trim()); | |
| return `${parseFloat(lat).toFixed(4)}, ${parseFloat(lng).toFixed(4)}`; | |
| }; |
FenixReloaded
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correções de Inicialização, Favoritos, Calendário, Exportações e Melhorias Gerais
Description
Este Pull Request reúne diversas correções, melhorias de UX, implementação de novas telas e ajustes funcionais importantes para garantir estabilidade, modernidade e melhor experiência do usuário no aplicativo.
Main Changes
Details of the Changes
How to Test
Related Issues
Nenhuma issue mencionada.
Checklist