Skip to content

Conversation

@nghuoyng
Copy link

@nghuoyng nghuoyng commented Nov 6, 2014

mission completed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里显示乱码是因为编码问题,请统一使用 UTF-8 编码

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件同样编码有问题,commit log尽量写有意义的信息,写清楚自己这个commit在干什么,可以用中文。而不要用无用重复的commit log

@SimplyY
Copy link
Member

SimplyY commented Nov 6, 2014

代码不算cleancode,请移步
http://www.jianshu.com/p/5364398f4d60
http://www.jianshu.com/p/21fa0c8e8672

@SimplyY SimplyY closed this Nov 6, 2014
@xcodebuild
Copy link
Contributor

不用close,所以更新的commit都会在同步

@xcodebuild xcodebuild reopened this Nov 6, 2014
@SimplyY
Copy link
Member

SimplyY commented Nov 7, 2014

我能说我按错键了么,,

@nghuoyng
Copy link
Author

nghuoyng commented Nov 7, 2014

嗯?怎么了 第一次写,格式可能有问题,见谅。------------------ 原始邮件 ------------------
发件人: "SimplyY"notifications@github.com
发送时间: 2014年11月7日(星期五) 上午9:15
收件人: "Jnrainerds/lesson-task"lesson-task@noreply.github.com;
抄送: "nghuoyng"1013975672@qq.com;
主题: Re: [lesson-task] huyong task (#6)

我能说我按错键了么,,


Reply to this email directly or view it on GitHub.

@xcodebuild
Copy link
Contributor

不要每次commit log都写一样的,这样会使commit失去意义。写清楚本次commit的作用,可以用中文。还有main函数太长,以及panduan这样的命名。。。。

@SimplyY
Copy link
Member

SimplyY commented Nov 7, 2014

上次培训的内容在这里
http://www.jianshu.com/p/5364398f4d60
http://www.jianshu.com/p/21fa0c8e8672

关于cleancode还是很重要的,请养成很好的命名规范和习惯,不懂的地方可以问韬韬,或者问我

@nghuoyng
Copy link
Author

nghuoyng commented Nov 7, 2014

嗯嗯,谢谢。------------------ 原始邮件 ------------------
发件人: "SimplyY"notifications@github.com
发送时间: 2014年11月7日(星期五) 中午1:57
收件人: "Jnrainerds/lesson-task"lesson-task@noreply.github.com;
抄送: "nghuoyng"1013975672@qq.com;
主题: Re: [lesson-task] huyong task (#6)

上次培训的内容在这里
http://www.jianshu.com/p/5364398f4d60
http://www.jianshu.com/p/21fa0c8e8672

关于cleancode还是很重要的,请养成很好的命名规范和习惯,不懂的地方可以问韬韬,或者问我


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants