Skip to content

env.get_action_mask function accesses wrong member #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DocDriven wants to merge 2 commits into
base: master
Choose a base branch
from
Open

env.get_action_mask function accesses wrong member #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b9bbf
Fix env.get_action_mask function
DocDriven Jan 28, 2026
278b4d8
Fix exploit probability upper limit in loader.py
DocDriven Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nasim/envs/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ def get_action_mask(self):
mask = np.zeros(self.action_space.n, dtype=np.int64)
for a_idx in range(self.action_space.n):
action = self.action_space.get_action(a_idx)
if self.network.host_discovered(action.target):
if self.current_state.host_discovered(action.target):
mask[a_idx] = 1
return mask

Expand Down
2 changes: 1 addition & 1 deletion nasim/scenarios/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def _validate_single_exploit(self, e_name, e):
(f"{e_name}. Exploit target OS is invalid. '{e[u.EXPLOIT_OS]}'."
" Should be None or one of the OS in the os list.")

assert 0 <= e[u.EXPLOIT_PROB] < 1, \
assert 0 <= e[u.EXPLOIT_PROB] <= 1.0, \
(f"{e_name}. Exploit probability, '{e[u.EXPLOIT_PROB]}' not "
"a valid probability")

Expand Down