Skip to content

fix : favicon issue in prod #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jittojoyes98 merged 5 commits into from
Sep 15, 2025
Merged

fix : favicon issue in prod #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8439a85
fix : favicon issue in prod
Jittojoyes98 Sep 15, 2025
b786c71
fix: upgrade node to v22
Jittojoyes98 Sep 15, 2025
571c25c
fix: changing to vite
Jittojoyes98 Sep 15, 2025
6a94d17
upgrade to node v22
Jittojoyes98 Sep 15, 2025
0e52188
fix: node version deployment issue
Jittojoyes98 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .babelrc
View file
Open in desktop

This file was deleted.

19 changes: 13 additions & 6 deletions .github/workflows/webpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: NodeJS with Webpack
name: NodeJS with Vite

on:
push:
Expand All @@ -12,17 +12,24 @@ jobs:

strategy:
matrix:
node-version: [18.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build

- name: Test build output
run: |
npm install
npx webpack
ls -la dist/
test -f dist/index.html || exit 1
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

**_Usage_**

- To run the server locally, run: `npm run serve`
- Your server will start at `http://localhost:3030`.
- To run the server locally, run: `npm run dev`
- Your server will start at `http://localhost:3000`.

**_What is Dropform?_**

Expand Down
15 changes: 15 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Dropform</title>
<link rel="icon" href="/favicon/favicon-16x16.png" type="image/x-icon" />
</head>

<body>
<div id="app"></div>
<script type="module" src="/src/index.jsx"></script>
</body>
</html>
Loading