Refactor invokeSpecialMethod for reflection parity#568
Merged
JingMatrix merged 1 commit intomasterfrom Mar 14, 2026
Merged
Conversation
We overhaul the `invokeSpecialMethod` backend to make it robust against JNI aborts and closer to standard Java reflection behavior, while maintaining reasonable performance.
Key improvements:
- Fix illegal `jclass{nullptr}` usage during return value boxing by globally caching primitive wrapper classes (`Integer`, `Double`, etc.).
- Eliminate heap allocations for argument mapping by replacing `std::vector` with stack-allocated memory via `alloca`.
- Prevent JNI type confusion crashes by introducing strict type validation (`IsInstanceOf`) before unboxing arguments.
- Safely catch native exceptions from the target method and wrap them in `InvocationTargetException`, mirroring `java.lang.reflect.Method.invoke`.
- Gracefully handle `null` receivers and zero-length argument arrays.
ljh520134
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We overhaul the
invokeSpecialMethodbackend to make it robust against JNI aborts and closer to standard Java reflection behavior, while maintaining reasonable performance.Key improvements:
jclass{nullptr}usage during return value boxing by globally caching primitive wrapper classes (Integer,Double, etc.).std::vectorwith stack-allocated memory viaalloca.IsInstanceOf) before unboxing arguments.InvocationTargetException, mirroringjava.lang.reflect.Method.invoke.nullreceivers and zero-length argument arrays.