Remove webui#345
Conversation
|
It is fine to co-exist for this monent. |
|
It is unnecessary to have two buttons with exactly the same function in the lsposed module of the root manager. One of them should be removed |
|
A webui is just useless to call the same thing that action calls, plus all root manager has actions and magisk alone doesn't have webui so it's just unnecessary to keep webroot |
|
You also need to remove the "generateWebRoot" Gradle action. |
|
You forgot to remove its caller, https://github.com/JingMatrix/LSPosed/blob/f081aa38990cbb9ec3d5a2787a5ec268fd9eed9e/magisk-loader/build.gradle.kts#L175 |
|
I will merge this when you finish cleaning the gradle configurations. |
|
Be patient, @Keeperorowner, this is not a urgent pull-request, we can still wait for some more comments (or not). |
|
This PR looks good to me. |
|
Please refer to f8409ad, and remove pnpm dependencies in GitHub Actions; |
The effects of webui and action are the same, so there is no need for both to exist simultaneously. Therefore, webui should be removed