Fix bug when converting OSDT leaves into a Text Classifier compatible…#3
Open
FernandoLpz wants to merge 1 commit intoJimmy-Lin:masterfrom
Open
Fix bug when converting OSDT leaves into a Text Classifier compatible…#3FernandoLpz wants to merge 1 commit intoJimmy-Lin:masterfrom
FernandoLpz wants to merge 1 commit intoJimmy-Lin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug when trying to validate if a
leafexists in thefeaturesdict. Essentially, aleafis a tuple with form:(feature_1, feature_2, ..., feature_n)and the
keysandvaluesof thefeaturesdict has the form:where
So the original
if-elsestatement, tried to validate if a tuple was infeatures, however features only contain integers for key and values. For some specific cases, it returned an empty dict which turn out into a recursivity problem.