Dependency Updates, Documentation Improvement, Client Side Storage, and Server Side List Users Feature#3
Open
JuneToJuly wants to merge 4 commits intoJigarJoshi:masterfrom
Open
Dependency Updates, Documentation Improvement, Client Side Storage, and Server Side List Users Feature#3JuneToJuly wants to merge 4 commits intoJigarJoshi:masterfrom
JuneToJuly wants to merge 4 commits intoJigarJoshi:masterfrom
Conversation
- Updated poms to exclude BouncyCastle, jar signature was being invalidated. - Bouncy Castle now placed with jre, and provider added to java.security - Updated poms to include latest sqlconnector version - Updated Client Demo for easier testing - Updated Client to support "logout", keys need to be written to disk. - Updated Client to support "loading" a user's keys from disk to memory - Updated Client config for user keystore, where keys are written - Updated Server to include "list users" - Fixed problem with "/register" post method - Fixed some other misc bugs
Link changed.
Removed some debug statements and cleaned up the pom.xml for building both the otr-server and client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jigar,
I may use your framework in the future and wanted to explain some of my changes.
I've made a couple of changes:
A few of the dependencies were out of date and I could not run the application. I made updates to the pom.xml and included some code changes that were necessary to use the updated dependencies. Specifically, I had to interact with Jackson, Bouncy Castle, MySql Connection, and Jetty.
I updated the readme to include more information about how to run the application. Specifically, I had not used Lithium Flow before and was unaware of how the config file was being included in the project.
I added a feature for client-side storage and loading of a user's keys. I suppose I may have gone a little against the interface you were trying to define by including a "write to disk" feature, but the current implementation did not allow for logging into another user that was already registered, or logging in after the client had been stopped.
I could have written a "Disk Storer", but it seemed more efficient to give the user the ability to write their key information to disk via the "logout" feature if they would like.
Also, the keys are stored in plaintext in a JSON file.
I was unsure how two parties might exchange user ids. I wrote a function that allowed a user to list all the users that were registered to the target ID could be identified.
I will be fairly busy over the next few weeks. If you don't like anything or are not maintaing anymore, let me know. I crammed a lot into a single pull.
Thanks,
Ian