fix: resolve lint issues and modernize code#1
Merged
Conversation
- Fix undefined name OrchestratorCallbacks in linkedin_scraper.py - Replace str, Enum with StrEnum for BotMode and ReviewDecision - Fix ambiguous variable name (l -> link) - Fix unused loop variable (i -> _) - Fix trailing whitespace in docstrings - Add OrchestratorCallbacks import in TYPE_CHECKING block - Configure ruff to ignore E501 (long lines in JS/prompts) and T201 (print statements) - Update ruff config to new [tool.ruff.lint] format
JienWeng
force-pushed
the
fix/lint-issues
branch
from
de333bb to
5a578f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrchestratorCallbacksin linkedin_scraper.pystr, EnumwithStrEnumforBotModeandReviewDecisionl->link)i->_)OrchestratorCallbacksimport in TYPE_CHECKING block[tool.ruff.lint]formatTest plan