rd-reflection: better pumping on sync calls#593
Merged
Conversation
Iliya-usov
approved these changes
Feb 23, 2026
added 2 commits
February 23, 2026 14:47
There is currently a race condition with the switching scheduler approach. If two calls start simultaneously from both ends with a small time gap, then a deadlock is possible. One way to address this issue is to introduce explicit pumping behavior for certain schedulers. This change is required for ReSharper OOP. The schedulers defined in Rd are modified only for testing purposes.
ulex
force-pushed
the
au/rd-reflection-pumping
branch
from
f59cb58 to
a55fb9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a race condition with the switching scheduler approach. If two calls start simultaneously from both ends with a small time gap, then a deadlock is possible.
One way to address this issue is to introduce explicit pumping behavior for certain schedulers. This change is required for ReSharper OOP. The schedulers defined in Rd are modified only for testing purposes.