Open
Conversation
ForNeVeR
commented
Aug 5, 2025
| public IPAddress? LocalAddress { get; private set; } | ||
| public int? LocalPort { get; private set; } | ||
| public string? LocalPath { get; private set; } | ||
| public abstract EndPoint EndPointImpl { get; } |
Collaborator
Author
There was a problem hiding this comment.
(Minor) Is there a reason to not call this EndPoint, without Impl?
There was a problem hiding this comment.
I try to avoid naming variables/properties the same as types to reduce confusion. Though, I do not like the Impl, so we can rename them.
Return old frameworks. Marked everything related to `UnixDomainSocketEndPoint` with `#if NET8_0_OR_GREATER` pragma.
Otherwise, it was possible that we acknowledge receival of a huge data chunk via PkgInputStream, but prematurely stop processing of this chunk in readMsg, because the socket was disconnected in-flight.
…ort both TCP and Unix socket addresses
…traction and update related logic
…e `SocketWire` implementations accordingly
Fantoom
force-pushed
the
im/UnixSockets
branch
from
e724525 to
e29a625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.