Skip to content

ByteBufferAsyncProcessor: prevent deadlocks on corrupted state exceptions #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForNeVeR merged 1 commit into from
Dec 20, 2020
Merged

ByteBufferAsyncProcessor: prevent deadlocks on corrupted state exceptions #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rd-net/Lifetimes/Threading/ByteBufferAsyncProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,9 @@ [PublicAPI] public void Put(UnsafeWriter.Cookie data)
}


#if !NET35
[System.Runtime.ExceptionServices.HandleProcessCorruptedStateExceptions] // to force myLock to be unlocked even in case of corrupted state exception
Copy link
Contributor

@sergeyQx sergeyQx Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have also added logging of the exception

Copy link
Collaborator Author

@ForNeVeR ForNeVeR Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a good idea! See #190.

#endif
[PublicAPI] public void Put(byte* start, int count)
{
if (count <= 0) return;
Expand Down