Add run gutter marks support for aspire file based apphost#625
Open
Fantoom wants to merge 4 commits intoaspire-file-apphostfrom
Open
Add run gutter marks support for aspire file based apphost#625Fantoom wants to merge 4 commits intoaspire-file-apphostfrom
Fantoom wants to merge 4 commits intoaspire-file-apphostfrom
Conversation
rafaelldi
approved these changes
Mar 20, 2026
|
|
||
|
|
||
| return when (cfg.configuration) { | ||
| is AspireHostConfiguration -> RunConfigurationExt(templateProfileName?.let { listOf(RunConfigurationEntry(RunConfigurationEntryKey.LaunchSettingsProfile, it)) } |
Collaborator
There was a problem hiding this comment.
minor: can you please reformat the file, this line is too long
rider/src/main/kotlin/com/jetbrains/aspire/rider/run/AspireConfigurationType.kt
Show resolved
Hide resolved
| namespace JetBrains.Rider.Aspire.Plugin.RunGutterMarks; | ||
|
|
||
| [SolutionComponent(Instantiation.DemandAnyThreadSafe)] | ||
| internal sealed class AspireTemplateProvider : IRunConfigurationTemplateProvider |
Collaborator
There was a problem hiding this comment.
Could use please reformat the file? In this repo we use a different indentation
| using JetBrains.ProjectModel; | ||
| using JetBrains.ProjectModel.Caches; | ||
| using JetBrains.ProjectModel.DotNetCore; | ||
| using JetBrains.ProjectModel.ProjectsHost; |
52ac418 to
9b21a70
Compare
292e8fa to
aa01c4d
Compare
aa01c4d to
6ce370f
Compare
f4c5cfe to
8584abd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.