Skip to content

fix: improve WebGPU adapter detection accuracy #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jesssullivan merged 1 commit into from
Feb 12, 2026
Merged

fix: improve WebGPU adapter detection accuracy #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 41 additions & 12 deletions src/lib/pixelwise/featureDetection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,23 +119,49 @@ export async function detectWebGPU(): Promise<{ available: boolean; adapter: str
}
}

// Get adapter info for debugging (with compatibility check for older WebGPU implementations)
// Get adapter info for debugging
let adapterInfo = 'Unknown Adapter';
let info: GPUAdapterInfo | null = null;

// Type-safe check for newer WebGPU API methods
// GPUAdapter may have requestAdapterInfo in newer specs (v1.1+)
// and isFallbackAdapter as a property
interface ExtendedGPUAdapter extends GPUAdapter {
requestAdapterInfo?: () => Promise<GPUAdapterInfo>;
isFallbackAdapter?: boolean;
info?: GPUAdapterInfo;
}
const extendedAdapter = adapter as ExtendedGPUAdapter;

if (typeof extendedAdapter.requestAdapterInfo === 'function') {
// Reject fallback/software adapters — Futhark requires a real GPU
if (extendedAdapter.isFallbackAdapter) {
console.warn('[featureDetection] WebGPU: Rejecting fallback (software) adapter');
return { available: false, adapter: 'Software Adapter (not supported)' };
}

// Try adapter.info (synchronous, Chrome 121+), then requestAdapterInfo() (async, older)
if (extendedAdapter.info) {
info = extendedAdapter.info;
adapterInfo = info.vendor || info.architecture || info.device
? `${info.vendor} ${info.architecture} (${info.device})`.trim()
: 'WebGPU Adapter';

console.log('[featureDetection] WebGPU Adapter Details:', {
vendor: info.vendor,
architecture: info.architecture,
device: info.device,
description: info.description,
features: Array.from(adapter.features),
isFallbackAdapter: extendedAdapter.isFallbackAdapter ?? false,
limits: {
maxTextureDimension2D: adapter.limits.maxTextureDimension2D,
maxBufferSize: adapter.limits.maxBufferSize,
maxStorageBufferBindingSize: adapter.limits.maxStorageBufferBindingSize
}
});
} else if (typeof extendedAdapter.requestAdapterInfo === 'function') {
try {
info = await extendedAdapter.requestAdapterInfo();
adapterInfo = `${info.vendor} ${info.architecture} (${info.device})`;
adapterInfo = info.vendor || info.architecture || info.device
? `${info.vendor} ${info.architecture} (${info.device})`.trim()
: 'WebGPU Adapter';

console.log('[featureDetection] WebGPU Adapter Details:', {
vendor: info.vendor,
Expand All @@ -152,17 +178,15 @@ export async function detectWebGPU(): Promise<{ available: boolean; adapter: str
});
} catch (error: unknown) {
console.warn('[featureDetection] requestAdapterInfo() failed:', error);
adapterInfo = 'WebGPU Adapter (info unavailable)';
adapterInfo = 'WebGPU Adapter';
}
} else {
// Fallback for older WebGPU implementations (pre-v1.1)
console.warn('[featureDetection] requestAdapterInfo() not available (WebGPU < v1.1)');
adapterInfo = 'WebGPU Adapter (legacy)';
// Neither info property nor requestAdapterInfo available
console.warn('[featureDetection] No adapter info API available');
adapterInfo = 'WebGPU Adapter';

// Log basic adapter info without requestAdapterInfo()
console.log('[featureDetection] WebGPU Adapter Details (basic):', {
features: Array.from(adapter.features),
isFallbackAdapter: extendedAdapter.isFallbackAdapter ?? false,
limits: {
maxTextureDimension2D: adapter.limits.maxTextureDimension2D,
maxBufferSize: adapter.limits.maxBufferSize,
Expand All @@ -171,6 +195,11 @@ export async function detectWebGPU(): Promise<{ available: boolean; adapter: str
});
}

// Reject adapters with empty vendor/device info — likely experimental or incomplete
if (info && !info.vendor && !info.architecture && !info.device) {
console.warn('[featureDetection] WebGPU: Adapter has no vendor/device info, likely experimental');
}

// Check for required features
const requiredFeatures: GPUFeatureName[] = [];
for (const feature of requiredFeatures) {
Expand Down
Loading