Second challenge by Jess2896 · Pull Request #2 · Jess2896/JS-training

Jess2896 · 2019-09-26T15:25:23Z

Calculates which team has the highest average score and prints the result in the console.
The extra part of this challenge consisted on adding a third team and determining which of the 3 has the highest average score.

Verification steps

Download both files(index.html and script.js) into a folder and then open the index.html file on a browser.
Inspect the website and open the console to see the result obtained.

oscarpolanco

Good job!!
Some comments that we can discuss

oscarpolanco · 2019-10-01T22:23:33Z

script.js

+let mikeTeamScores = [116,94,123];
+let johnsAvrg = calcAverage(johnTeamScores);
+let mikesAvrg = calcAverage(mikeTeamScores);
+let hasHigherScore = johnsAvrg > mikesAvrg? "John's team has a higher average of " + johnsAvrg : "Mike's team has a higher average of " + mikesAvrg;


Missing spaces here

I think we can update the conditions, but first I would like to read if you have another approach to change these conditions.

The other option i can think of is to save the possible results in variables so the code is easier to read.

Can we store the winner on some kind of structure like an object so we don't need to repeat the string so many times?

Changed it, is it fine like this?

oscarpolanco · 2019-10-01T22:23:48Z

script.js

+let johnsAvrg = calcAverage(johnTeamScores);
+let mikesAvrg = calcAverage(mikeTeamScores);
+let hasHigherScore = johnsAvrg > mikesAvrg? "John's team has a higher average of " + johnsAvrg : "Mike's team has a higher average of " + mikesAvrg;
+let avrg = johnsAvrg == mikesAvrg? "John's and Mike's teams have the same average score" : hasHigherScore;


Missing space here

oscarpolanco · 2019-10-01T22:24:30Z

script.js

+let maryAvrg = calcAverage(maryTeamScores);
+let winner = "The three teams are tied";
+
+if (maryAvrg > johnsAvrg && maryAvrg> mikesAvrg) {


Missing space here

oscarpolanco · 2019-10-01T22:25:15Z

script.js

+    scores.forEach(score => {
+        sum += score;
+    });
+    return sum/scores.length;


Missing space here

oscarpolanco · 2019-10-01T22:27:15Z

script.js

@@ -0,0 +1,35 @@
+let johnTeamScores = [89,20,103];


I think you should re-check this definition.
Can you give me some inside about let, const and var?

The main difference between var and let is that let is block-scoped instead of function-scoped, which is considered a better coding practice. Let also doesn't allow you to access a variable before its declared.

On the other hand, const is similar to let, the difference being that you can't assign a new value to the variable.

I realized I should have declared the scores as const since I don't need to change these values. Fixed the code.

oscarpolanco · 2019-10-01T22:29:25Z

script.js

@@ -0,0 +1,35 @@
+let johnTeamScores = [89,20,103];


Missing spaces here

oscarpolanco · 2019-10-01T22:29:36Z

script.js

@@ -0,0 +1,35 @@
+let johnTeamScores = [89,20,103];
+let mikeTeamScores = [116,94,123];


Missing spaces here

oscarpolanco · 2019-10-01T22:31:23Z

script.js

+
+//Extra
+
+let maryTeamScores = [97,134,105];


Missing spaces here

oscarpolanco · 2019-10-14T15:20:23Z

script.js

+    higherAverage.highestAvrg = '';
+}
+
+const avrg = higherAverage.winner + higherAverage.highestAvrg + higherAverage.score;


On Es6 were introduce the template literals. We can use it here instead of storing the complete string value; just need to put it twice in case there was a tie.

oscarpolanco · 2019-10-14T15:31:52Z

script.js

+
+higherAverage.setWinner();
+
+function calcAverage(scores) {


Hello can we add some documentation for the code here and here are some examples

Jess2896 changed the title ~~Calculates which team has the highest average score~~ Second challenge Sep 26, 2019

Jess2896 force-pushed the second-challenge branch from 25e0b22 to 3c1e335 Compare September 26, 2019 17:24

Calculates which team has the highest average score

ef740e4

Jess2896 force-pushed the second-challenge branch from 3c1e335 to ef740e4 Compare September 26, 2019 17:25

Jess2896 requested a review from oscarpolanco September 30, 2019 15:53

Fixed the code's format

9ab399e

Jess2896 force-pushed the second-challenge branch from 5cb1605 to 9ab399e Compare September 30, 2019 16:34

oscarpolanco requested changes Oct 1, 2019

View reviewed changes

Jess2896 force-pushed the second-challenge branch 4 times, most recently from 86428b0 to 81dd312 Compare October 7, 2019 14:51

Fixed spaces and the some variables declarations

2c6052a

Jess2896 force-pushed the second-challenge branch 5 times, most recently from 33dedfe to d6134d7 Compare October 14, 2019 15:04

oscarpolanco reviewed Oct 14, 2019

View reviewed changes

Jess2896 force-pushed the second-challenge branch 5 times, most recently from c08f800 to 1603edf Compare October 15, 2019 15:52

Fixed repeated string

f3be13a

Jess2896 force-pushed the second-challenge branch from 1603edf to f3be13a Compare October 15, 2019 15:53

		@@ -0,0 +1,35 @@
		let johnTeamScores = [89,20,103];
		let mikeTeamScores = [116,94,123];


		higherAverage.setWinner();

		function calcAverage(scores) {

Conversation

Jess2896 commented Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oscarpolanco left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jess2896 Oct 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Jess2896 commented Sep 26, 2019 •

edited

Loading

Jess2896 Oct 4, 2019 •

edited

Loading