chore: update pr-review-axrun workflow and AGENTS.md #11
Conversation
Sync workflow with latest changes from review-tests. Adds npm hardening: force registry, enforce TLS, ignore user config.
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the pr-review-axrun.yml workflow with the latest version and updates documentation in AGENTS.md to use consistent date handling patterns.
Changes:
- Added npm security hardening configuration (registry enforcement, TLS requirements, user config isolation)
- Updated
AGENTS.mdcode examples to usenew Date()instead ofDate.now()for consistency - Pinned
axinstallandaxrunpackages to@latestversions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/pr-review-axrun.yml |
Added npm hardening environment variables and pinned package versions to @latest for both axinstall and axrun commands |
AGENTS.md |
Updated code examples to use new Date() instead of Date.now() for date comparisons |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| function sendUserExpiryEmail(): void { | ||
| for (const user of db.getUsers()) { | ||
| if (user.subscriptionEndDate > Date.now()) continue; | ||
| if (user.subscriptionEndDate > new Date()) continue; |
There was a problem hiding this comment.
Comparing a date property directly with new Date() may fail if user.subscriptionEndDate is a number (timestamp). The original Date.now() returned a number, but new Date() returns a Date object. If subscriptionEndDate is stored as a timestamp number, this comparison will not work as intended. Consider using new Date().getTime() or keeping Date.now() for numeric timestamp comparisons.
| if (user.subscriptionEndDate > new Date()) continue; | |
| if (user.subscriptionEndDate > Date.now()) continue; |
| // Imperative shell - handles side effects | ||
| email.bulkSend( | ||
| generateExpiryEmails(getExpiredUsers(db.getUsers(), Date.now())), | ||
| generateExpiryEmails(getExpiredUsers(db.getUsers(), new Date())), |
There was a problem hiding this comment.
Passing new Date() instead of Date.now() changes the parameter type from number to Date object. If getExpiredUsers expects a numeric timestamp, this will cause a type mismatch. Verify that the function signature accepts a Date object, or use new Date().getTime() to maintain backward compatibility.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
pr-review-axrun.ymlworkflow with latest version