Skip to content

Conversation

@Jercik
Copy link
Owner

@Jercik Jercik commented Jan 13, 2026

Summary

  • Replace eslint-config-axpoint with eslint-config-axkit as part of the package consolidation under the axkit branding

Test plan

  • pnpm install succeeds
  • pnpm lint passes

Replace eslint-config-axpoint with eslint-config-axkit as part of the
package consolidation under the axkit branding.
Copilot AI review requested due to automatic review settings January 13, 2026 11:09
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Details

No architectural concerns noted for this config-only change.

Summary: Found 0 issues. The ESLint config rename is straightforward and consistent across config and lockfile.


Review by Codex (gpt-5.2-codex)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Details

Files examined:

  • eslint.config.js - Import renamed from axpoint to axkit
  • package.json - Dependency renamed from eslint-config-axpoint to eslint-config-axkit
  • pnpm-lock.yaml - Lockfile updated accordingly

Verification performed:

  • Confirmed eslint-config-axkit@1.0.0 exists on npm (published 2026-01-10)
  • Confirmed the old eslint-config-axpoint package exists and appears to be the predecessor
  • Both packages are maintained by the same author (jercik)
  • The API shape is identical: axpoint({ gitignorePath })axkit({ gitignorePath })

What looks good:

  • Clean 1:1 rename with no functional changes
  • The lockfile shows the new package has nearly identical dependencies (same eslint plugins, same typescript-eslint version)
  • Minor transitive dependency updates (globals 16.5.0 → 17.0.0, @eslint-community/eslint-utils 4.9.0 → 4.9.1) are expected

Summary: ℹ️ No issues found. This is a straightforward package rename from eslint-config-axpoint to eslint-config-axkit with no API changes.


Review by Claude (opus)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project from eslint-config-axpoint to eslint-config-axkit as part of a package consolidation effort under the axkit branding.

Changes:

  • Updated package dependency from eslint-config-axpoint to eslint-config-axkit
  • Updated ESLint configuration to use the axkit export instead of axpoint
  • Updated lock file to reflect the new package and its updated dependencies

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Updated devDependency from eslint-config-axpoint to eslint-config-axkit
eslint.config.js Updated import and export to use axkit instead of axpoint
pnpm-lock.yaml Updated package resolutions, snapshots, and transitive dependencies for the new eslint-config-axkit package
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Details

The PR replaces the linter configuration with eslint-config-axkit. This appears to be a standard maintenance update.

Summary: Found 1 medium issue regarding potential linter rule conflicts with CLI patterns.


Review by Gemini (gemini-3-pro-preview)

const gitignorePath = path.join(import.meta.dirname, ".gitignore");

export default axpoint({ gitignorePath });
export default axkit({ gitignorePath });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium: Verify that eslint-config-axkit is suitable for CLI applications. If it enforces no-console or no-process-exit rules (common in web configs), this will break linting for this project, which relies heavily on them (e.g., in src/cli.ts and src/worktree/remove-worktree.ts).

@Jercik Jercik merged commit 443bc3a into main Jan 13, 2026
12 of 13 checks passed
@Jercik Jercik deleted the chore/migrate-eslint-config-axkit branch January 13, 2026 11:22
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants