-
Notifications
You must be signed in to change notification settings - Fork 0
chore: migrate from eslint-config-axpoint to eslint-config-axkit #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace eslint-config-axpoint with eslint-config-axkit as part of the package consolidation under the axkit branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review Details
No architectural concerns noted for this config-only change.
Summary: Found 0 issues. The ESLint config rename is straightforward and consistent across config and lockfile.
Review by Codex (gpt-5.2-codex)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review Details
Files examined:
eslint.config.js- Import renamed fromaxpointtoaxkitpackage.json- Dependency renamed fromeslint-config-axpointtoeslint-config-axkitpnpm-lock.yaml- Lockfile updated accordingly
Verification performed:
- Confirmed
eslint-config-axkit@1.0.0exists on npm (published 2026-01-10) - Confirmed the old
eslint-config-axpointpackage exists and appears to be the predecessor - Both packages are maintained by the same author (jercik)
- The API shape is identical:
axpoint({ gitignorePath })→axkit({ gitignorePath })
What looks good:
- Clean 1:1 rename with no functional changes
- The lockfile shows the new package has nearly identical dependencies (same eslint plugins, same typescript-eslint version)
- Minor transitive dependency updates (globals 16.5.0 → 17.0.0, @eslint-community/eslint-utils 4.9.0 → 4.9.1) are expected
Summary: ℹ️ No issues found. This is a straightforward package rename from eslint-config-axpoint to eslint-config-axkit with no API changes.
Review by Claude (opus)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the project from eslint-config-axpoint to eslint-config-axkit as part of a package consolidation effort under the axkit branding.
Changes:
- Updated package dependency from
eslint-config-axpointtoeslint-config-axkit - Updated ESLint configuration to use the
axkitexport instead ofaxpoint - Updated lock file to reflect the new package and its updated dependencies
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated devDependency from eslint-config-axpoint to eslint-config-axkit |
| eslint.config.js | Updated import and export to use axkit instead of axpoint |
| pnpm-lock.yaml | Updated package resolutions, snapshots, and transitive dependencies for the new eslint-config-axkit package |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review Details
The PR replaces the linter configuration with eslint-config-axkit. This appears to be a standard maintenance update.
Summary: Found 1 medium issue regarding potential linter rule conflicts with CLI patterns.
Review by Gemini (gemini-3-pro-preview)
| const gitignorePath = path.join(import.meta.dirname, ".gitignore"); | ||
|
|
||
| export default axpoint({ gitignorePath }); | ||
| export default axkit({ gitignorePath }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium: Verify that eslint-config-axkit is suitable for CLI applications. If it enforces no-console or no-process-exit rules (common in web configs), this will break linting for this project, which relies heavily on them (e.g., in src/cli.ts and src/worktree/remove-worktree.ts).
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
eslint-config-axpointwitheslint-config-axkitas part of the package consolidation under the axkit brandingTest plan
pnpm installsucceedspnpm lintpasses