Open
Conversation
Owner
|
Hi — I’ll take a look when I have some spare time. Right now I have a GitHub Action that clones cldr-json once a month and opens a PR to update the files. That means changes that aren’t in CLDR could get overwritten by my CI. I use the CLDR-json project as the source of truth for locale data, so I need to figure out how to accept community contributions to datify-core without losing them. One idea I had is an “overlay” system you can toggle on, for example with community: true. When enabled, the overlay would override some outputs with community-provided data. That way people could choose between community-driven data or the CLDR data that we currently use as the standard. |
Author
|
Ah I see! That's a pity that it is solved in that way there ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @Jeomhps ,
I recently saw all the changes in
datifyand I'm really impressed! For the Portuguese part, I think some changes might be helpful (at least from my experience living in Brazil, don't know about Portugal). Both versions (formatandstand-alone) have right now the same output inpt. I think it might be better to have one version with capital letter (I changed instand-alone), since, for example, using the month at the end of a title page likeNovembro de 2025would be with starting capital.Furthermore, I did change the narrow abbreviation for days, since it is even more ambiguous than with month, since there 3 days beginning with
Sand two withQ. In Portuguese, it's quite common to use2ªuntil6ªfor Monday to Friday and thenSfor sábado eDfor domingo. The last two are not common (common would beSáb.ouDom.), but for Monday to Friday it is common.