feat(bulk-entry): add bulk entry workflow for snapshot creation

[Jench2103]

Summary

Adds a new "Bulk Entry" mode as the default snapshot creation workflow. Instead of creating empty snapshots or copying from the latest, users now get a full-screen editable table with all assets from the prior snapshot grouped by platform, where they can enter new market values directly or import them from per-platform CSV files. This replaces the previous "Copy from latest" option and provides a significantly more efficient data entry experience.

Changes

• Bulk Entry ViewModel & Types

  • BulkEntryViewModel with platform-grouped rows, save logic (zero-value fallback for pending rows), and per-platform CSV import with match/append semantics
  • BulkEntryRow value type with rich state tracking (updated, pending, excluded, validation errors, zero-value detection, duplicate name detection)
  • CSVImportResult with formatted user-facing messages for match counts, errors, and warnings

• Bulk Entry View

  • BulkEntryView with platform-grouped table, keyboard navigation (Tab/Enter between fields), and toolbar with progress stats, validation warnings, and save button
  • BulkEntrySubviews extracted as structs: progress stats, validation warnings, platform section headers, asset rows, empty state, and glass-style toolbar
  • Inline asset creation with name, currency, and category picker per platform group
  • "Add Platform" toolbar popover for creating new platform groups
  • Per-platform CSV import via file picker

• Snapshot List & Navigation

  • Updated NewSnapshotSheet to replace "Copy from latest" toggle with a creation mode picker (Empty / Bulk Entry)
  • ContentView updated to navigate to BulkEntryView when bulk entry mode is selected
  • Zero-value warning icons on snapshot list rows and snapshot detail asset rows via new HoverWarningIcon component

• CSV Import Enhancement

  • ImportViewModel+Helpers now allows CSV import to overwrite zero-value assets in existing snapshots (deferred from bulk entry pending rows)

• Utilities

  • WhenUnlockedModifiers extended with helpWhenUnlocked(_ text: String) overload; HelpWhenUnlockedModifier stabilized to always apply .help() (avoiding @FocusState resets from view tree changes)

• Localization

  • Full Traditional Chinese (zh-Hant) translations for all bulk entry strings in Localizable.xcstrings and Snapshot.xcstrings

• Documentation

  • Updated SPEC.md, BusinessLogic.md, and UserInterfaceDesign.md with bulk entry feature spec, validation rules, save semantics, and implementation status
  • Added user-facing bulk entry guide for MkDocs (English and zh-TW) with screenshots

• Tests

  • 751-line BulkEntryViewModelTests covering row state logic, platform grouping, counts, save semantics (including zero-value fallback and new asset creation), CSV import matching/appending/re-import, manual row/platform CRUD, duplicate name detection, and category resolution
  • SnapshotListViewModelTests extended with zero-value asset detection tests

Testing

• Unit tests: BulkEntryViewModelTests (25 tests) and SnapshotListViewModelTests (2 new tests) using Swift Testing with in-memory SwiftData containers
• Manual testing: snapshot creation via bulk entry (empty state, with prior data), per-platform CSV import, inline asset/platform creation, keyboard navigation, zero-value warnings, cancel/discard flows

Notes

• The "Copy from latest" creation mode has been replaced by "Bulk Entry" as the default. "Start empty" remains available.
• Pending rows (included but no value entered) are saved with market value 0, triggering zero-value warnings in the snapshot detail and list views to prompt the user to update them later.
• New categories typed during bulk entry are created in the database only on save (deferred creation).

[Jench2103]

Code review

Found 4 issues:

1. canSave does not guard against rows with validation errors -- invalid text silently saved as 0. A row with non-parseable text (e.g. "abc") has newValue == nil and shows a red border, but the user can still click Save. In saveSnapshot(), row.newValue ?? Decimal(0) silently converts the invalid input to 0. Fix: add && !rows.contains(where: { $0.isIncluded && $0.hasValidationError }) to canSave.

asset-flow/AssetFlow/ViewModels/BulkEntryViewModel.swift

Lines 63 to 66 in bf06caa

	var hasDuplicateNames: Bool { !duplicateNameRowIDs.isEmpty }
	var canSave: Bool {
	includedCount > 0 && zeroValueCount == 0 && !hasInvalidNewRows && !hasDuplicateNames
	}

2. "Empty Snapshot" option always fails when triggered from sidebar. The sidebar "New Snapshot" click shows NewSnapshotSheet without passing a viewModel. The sheet still presents both "Empty Snapshot" and "Bulk Entry" radio buttons. Selecting "Empty Snapshot" hits guard let viewModel and shows an error alert. The option should be hidden or disabled when viewModel is nil.

asset-flow/AssetFlow/Views/SnapshotListView.swift

Lines 347 to 354 in bf06caa

	}
	guard let viewModel else {
	errorMessage = String(
	localized: "Cannot create an empty snapshot from this context.",
	table: "Snapshot")
	showError = true
	return
	}

asset-flow/AssetFlow/Views/ContentView.swift

Lines 178 to 186 in bf06caa

	.sheet(isPresented: $showBulkEntrySheet) {
	NewSnapshotSheet(
	onBulkEntry: { date in
	bulkEntryViewModel = BulkEntryViewModel(
	modelContext: modelContext, date: date)
	pushHistory(.bulkEntry)
	}
	)
	}

3. Sidebar "New Snapshot" bypasses importCSV unsaved-changes guard. In sidebarBinding, the .bulkEntry check at line 259 returns early before the unsaved-changes guard at line 265. A user on the Import CSV screen with unsaved changes can click "New Snapshot" and silently lose their import data with no confirmation dialog.

asset-flow/AssetFlow/Views/ContentView.swift

Lines 258 to 274 in bf06caa

	// Bulk entry: show date picker sheet instead of navigating
	if newSection == .bulkEntry {
	showBulkEntrySheet = true
	return
	}
	// Check if navigating away from section with unsaved changes
	if selectedSection == .importCSV,
	importViewModel?.hasUnsavedChanges == true
	{
	pendingSection = newSection
	showDiscardConfirmation = true
	} else if selectedSection == .bulkEntry,
	bulkEntryViewModel?.hasUnsavedChanges == true
	{
	pendingSection = newSection
	showDiscardConfirmation = true

4. Stale documentation -- "Copy from latest" still referenced in UserInterfaceDesign.md (CLAUDE.md says "Before completing any task, review and update affected docs. UI/screen -> UserInterfaceDesign.md"). The New Snapshot Sheet section still documents the removed "Copy from latest" toggle. Both SPEC.md and BusinessLogic.md were correctly updated, but UserInterfaceDesign.md was not.

asset-flow/Documentation/UserInterfaceDesign.md

Lines 143 to 147 in bf06caa

	1. Starting point selector:
	- **Start empty**: Creates snapshot with no asset entries
	- **Copy from latest**: Pre-populates with all direct SnapshotAssetValues from the most recent prior snapshot. Disabled (grayed out with explanatory text) when no snapshots exist before the selected date.
	- **Bulk Entry**: Opens `BulkEntryView` for full-screen bulk value entry. Disabled when no assets exist.
	1. On creation, user is taken to the snapshot detail view for editing

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[Jench2103]

Original review

All 4 reported issues (plus 8 additional issues found below the reporting threshold) have been addressed in be6f175.

Reported issues fixed:

1. canSave now guards against hasValidationError rows
2. "Empty Snapshot" works from sidebar (creates snapshot via modelContext directly)
3. Sidebar unsaved-changes guard now runs before .bulkEntry sheet trigger
4. UserInterfaceDesign.md updated — removed stale "Copy from latest", fixed Bulk Entry description

Additional fixes:

• HelpWhenUnlockedStringModifier uses stable always-emit .help() pattern
• addPlatform() uses normalizedForIdentity instead of .lowercased()
• Added "Import Error" to Snapshot.xcstrings with zh-Hant translation
• Documented zero-value SAV placeholder invariant in code comments and BusinessLogic.md
• Forward history truncated on bulk entry discard to prevent nil ViewModel navigation
• Empty-state "Add Platform" popover anchored to its own button
• ContentView doc comment updated to 8-section sidebar
• Removed unused localization string

🤖 Generated with Claude Code