Conversation
discospiff
reviewed
Apr 3, 2022
| var permissionGranted = false | ||
| resultsMap.forEach { | ||
| if (it.value == true) { | ||
| if (it.value) { |
There was a problem hiding this comment.
A good suggestion, though it appeared in a previous review. When that happens, first in wins.
discospiff
reviewed
Apr 3, 2022
| fun fetchIncidents(fromCaseYear: Int, toCaseYear: Int, state: Int, county: Int){ | ||
| viewModelScope.launch { | ||
| var innerIncidents = incidentService.fetchIncidents(fromCaseYear, toCaseYear, state, county) | ||
| val innerIncidents = incidentService.fetchIncidents(fromCaseYear, toCaseYear, state, county) |
There was a problem hiding this comment.
A good suggestion, though it appeared in a previous review. When that happens, first in wins.
discospiff
reviewed
Apr 3, 2022
| super.onCreate(savedInstanceState) | ||
| setContent { | ||
| FreeWaysTheme() { | ||
| FreeWaysTheme{ |
There was a problem hiding this comment.
A good suggestion, though it appeared in a previous review. When that happens, first in wins.
discospiff
reviewed
Apr 3, 2022
| way2 = inWay2 | ||
| vehiclesInvolved = 0 | ||
|
|
||
| Card { |
There was a problem hiding this comment.
Are you adding styling to the Card? If not, is the card adding value?
|
Some good suggestions here, but most were covered in previous reviews. No need to merge the same change more than once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis of the program:
Was the program available in UC Github on time?
Yes
Is the program documented/commented well enough for you to understand?
Yes
Does the program compile?
Yes
Rationale behind your changes.
The text in the outlined text fields were cutting off for me so adding the Card fixed that. The rest were removing unnecessary parentheses and changing from var to val.
Links to three specific commits that you made to your own group's GitHub repository after Sprint 1's deadline, and before Sprint 2's deadline.
ahlersml/MyCleaningLog@9a344d2
ahlersml/MyCleaningLog@67097ed
ahlersml/MyCleaningLog@e44cba9
Technical Concepts
I learned more about working with the camera.
Working with different Card properties such as OutlinedTextField
Learned more about state holders ( by remember { mutableStateOf("") } )