Skip to content

feat!: Run function enhancements #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
c-dilks merged 26 commits into from
Oct 21, 2025
Merged

feat!: Run function enhancements #364

c-dilks merged 26 commits into from
Oct 21, 2025

Conversation

@c-dilks
Copy link
Member

@c-dilks c-dilks commented Aug 31, 2025 •
edited
Loading

  • Algorithm::Run functions have changed
    • new algorithm-specific "specialized" Run functions, which operate on lvalue references to banks
      • compatible with clas12reader's hipo::bank-derived objects
      • compatible with anyone that doesn't use hipo::banklist
      • the original Run(hipo::banklist&) functions simply call the specialized Run functions
    • all Run functions now return bool, providing an event-level filter, closing event-level filtering #352
      • users do not have to use the return value, so this shouldn't be a breaking change for anyone
  • required for clas12root support in feat: fully support Iguana and add documentation webpage clas12root#101

@github-project-automation github-project-automation bot moved this to Unsorted in Iguana Aug 31, 2025
@c-dilks c-dilks mentioned this pull request Aug 31, 2025
Merged
@c-dilks c-dilks linked an issue Sep 11, 2025 that may be closed by this pull request
event-level filtering #352
Closed
@c-dilks c-dilks force-pushed the clas12root-support branch from 5f85a29 to eb53fa0 Compare October 15, 2025 02:03
@c-dilks c-dilks changed the title feat: support for clas12root clas12reader feat!: Run function enhancements Oct 16, 2025
c-dilks added 23 commits October 17, 2025 18:56
@c-dilks
feat: support for clas12root clas12reader
ffd067f 
- new `Algorithm::CreateBank` to _just_ create a new Iguana bank, to be
  owned by the caller
- algorithm-specific `Run` functions, which operate on lvalue references
  to banks (compatible with `clas12reader`s raw pointers to
  `hipo::bank`-derived objects)
@c-dilks
feat: map creator algorithm to its created bank name
599c3c1
@c-dilks
feat: some improvements
1cb5cb8
@c-dilks
fix: undefined reference to iguana::AlgorithmFactory::s_algo_to_banks
99101ff
@c-dilks
feat: iguana_ex_cpp_00_run_functions_with_banks
aa284fc
@c-dilks
feat: more Run functions
649b8cd
@c-dilks
feat: another run function
d31ff3f
@c-dilks
feat: Run functions return bool as event-level filter
85886bc
@c-dilks
fix: bank name
6e61955
@c-dilks
fix: make it easier to get created bank names from AlgorithmSequence
3f4d81f
@c-dilks
feat: more Run functions
d23bd92
@c-dilks
feat: done with clas12::'s Run functions
438f671
@c-dilks
feat: done with all the Run functions
c3ff3b5
@c-dilks
doc: update algorithm docstrings
94eeb73
@c-dilks
doc: better run function docstrings
5b21ed8
@c-dilks
doc: link to run functions in brief
edece9a
@c-dilks
fix: update RGAFiducialFilter
2ed9124
@c-dilks
fix: implement useful Run function return values
126b366
@c-dilks
doc: reference for RGAFiducialFilter
4fd0dd3
@c-dilks
fix: captures are actually needed
be150f5
@c-dilks
doc!: make created-bank tables, so users don't have to understand JSON
b5f3a10
@c-dilks
doc: usage flowchart
65314a8
@c-dilks
doc: various improvements
a0e84a8
@c-dilks c-dilks force-pushed the clas12root-support branch from 7012e6a to a0e84a8 Compare October 17, 2025 22:56
@c-dilks c-dilks marked this pull request as ready for review October 20, 2025 23:21
@c-dilks c-dilks merged commit d0c176e into main Oct 21, 2025
14 checks passed
@c-dilks c-dilks deleted the clas12root-support branch October 21, 2025 14:00
@github-project-automation github-project-automation bot moved this from Unsorted to Done in Iguana Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtysonCLAS12 rtysonCLAS12 Awaiting requested review from rtysonCLAS12 rtysonCLAS12 is a code owner

@Gregtom3 Gregtom3 Awaiting requested review from Gregtom3 Gregtom3 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Iguana
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

event-level filtering

2 participants

@c-dilks