-
Notifications
You must be signed in to change notification settings - Fork 12
cpp TOF and FCAL trigger factory #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please exclude the hddm binary files from the PR. They must have been added accidentally. |
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^jan29-cpp-trigger/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^jan29-cpp-trigger/make_jan29-cpp-trigger.log |
a6ce224 to
784a7b5
Compare
784a7b5 to
3ab258c
Compare
|
Ok, only the 3 trigger files are listed under the "Files changed" tab, so I think it's good to go. |
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^jan29-cpp-trigger/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^jan29-cpp-trigger/make_jan29-cpp-trigger.log |
|
Ilya has some further changes he wants to add, which I will test today and then I will reopen the request. |
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^jan29-cpp-trigger/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^jan29-cpp-trigger/make_jan29-cpp-trigger.log |
Ilya has added an updated FCAL and TOF Trigger for CPP.
The modified files are:
TRIGGER_init.cc
DL1MCTrigger_factory_CPP.h
DL1MCTrigger_factory_CPP.cc
It doesn’t require any extra flags.
The factory needs to be called as:
vector<const DL1MCTrigger*> trigs_cpp;
event->Get(trigs_cpp, "CPP");