Remove security and quality targets from Makefile#970
Closed
Conversation
Removed security and quality targets from Makefile. Signed-off-by: Thomas Schmelzer <thomas.schmelzer@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the repo-owned security and semgrep targets from the root Makefile, leaving only the remaining custom targets and relying more on the Rhiza-included makefiles.
Changes:
- Deleted the root
securitytarget implementation (pip-audit + bandit). - Deleted the root
semgreptarget implementation. - Removed the associated help-section headers (
##@ Security,##@ Quality) from the rootMakefile.
| printf "${YELLOW}[WARN] SOURCE_FOLDER '${SOURCE_FOLDER}' not found, skipping semgrep.${RESET}\n"; \ | ||
| fi | ||
|
|
||
| .PHONY: adr |
There was a problem hiding this comment.
Removing the semgrep make target will break CI: both .github/workflows/rhiza_weekly.yml and .gitlab/workflows/rhiza_weekly.yml invoke make semgrep. With this change, those jobs will fail with “No rule to make target 'semgrep'”. Either keep/relocate the semgrep target (e.g., into .rhiza/make.d/*.mk) or update/remove the corresponding workflow steps in the same PR so CI remains green.
Suggested change
| .PHONY: adr | |
| .PHONY: semgrep adr | |
| semgrep: ## Compatibility target for CI workflows that invoke `make semgrep` | |
| @if command -v semgrep >/dev/null 2>&1; then \ | |
| semgrep scan; \ | |
| else \ | |
| echo "semgrep is not installed; skipping compatibility target."; \ | |
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed security and quality targets from Makefile.