Skip to content

Split bootstrap.mk into bootstrap.mk (non-Go) and bootstrap-go.mk (Go)#31

Open
Copilot wants to merge 3 commits intomainfrom
copilot/split-bootstrap-files
Open

Split bootstrap.mk into bootstrap.mk (non-Go) and bootstrap-go.mk (Go)#31
Copilot wants to merge 3 commits intomainfrom
copilot/split-bootstrap-files

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 24, 2026

bootstrap.mk mixed Go-specific and general tooling concerns into a single file. This PR splits it along that boundary.

Split

.rhiza/make.d/bootstrap-go.mk (new) — Go-specific content:

  • GO_VERSION, GO_BIN, GOPROXY variables
  • install-go — verifies Go installation against .go-version
  • installgo mod download/tidy + dev tool installation (golangci-lint, goimports, govulncheck, etc.)
  • build — compiles binaries to bin/

.rhiza/make.d/bootstrap.mk (trimmed) — non-Go content only:

  • pre-install / post-install hook stubs
  • install-uv — uv/uvx installation
  • clean — artifact removal, git cache cleanup, stale branch pruning

Downstream impact

Both files are picked up automatically via the existing glob in rhiza.mk:

-include .rhiza/make.d/*.mk

bootstrap-go.mk is added to the core bundle in template-bundles.yml so downstream projects receive both files on sync.

docs/ARCHITECTURE.md and README.md updated to reflect the new file.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • get.anchore.io
    • Triggering command: /usr/bin/curl curl -w %{http_code} -sL -o /tmp/tmp.7L10oJbDjk REDACTED commit (dns block)
    • Triggering command: /usr/bin/curl curl -w %{http_code} -sL -o /tmp/tmp.Lru17fbNFu REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Split bootstrap.mk into two files</issue_title>
<issue_description>One file bootstrap-go.mk for everything go
and
one file bootstrap.mk for everything else but no go</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@tschm
Copy link
Copy Markdown
Member

tschm commented Feb 24, 2026

@HarryCampion bootstrap.mk will be in rhiza-core. Same idea will be applied for rhiza

@tschm tschm marked this pull request as ready for review February 24, 2026 18:04
…mk (Go)

Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Copilot AI changed the title [WIP] Split bootstrap.mk into bootstrap-go.mk and bootstrap.mk Split bootstrap.mk into bootstrap.mk (non-Go) and bootstrap-go.mk (Go) Feb 24, 2026
Copilot AI requested a review from tschm February 24, 2026 18:07
@HarryCampion
Copy link
Copy Markdown
Collaborator

@HarryCampion bootstrap.mk will be in rhiza-core. Same idea will be applied for rhiza

If you try the new sync with cruft you may be able to get around having to call them bootstrap-.py worth a try

@tschm
Copy link
Copy Markdown
Member

tschm commented Feb 25, 2026

@HarryCampion bootstrap.mk will be in rhiza-core. Same idea will be applied for rhiza

If you try the new sync with cruft you may be able to get around having to call them bootstrap-.py worth a try

Not sure I understand. I will now create some more tests in rhiza-cli to mimick a changing template.yml file.

@HarryCampion
Copy link
Copy Markdown
Collaborator

@HarryCampion bootstrap.mk will be in rhiza-core. Same idea will be applied for rhiza

If you try the new sync with cruft you may be able to get around having to call them bootstrap-.py worth a try

Not sure I understand. I will now create some more tests in rhiza-cli to mimick a changing template.yml file.

cruft can handle the merge, instead of override, so you may be able to have the bootstrap in both locations and just extend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split bootstrap.mk into two files

3 participants