Conversation
AsyncBanana
left a comment
AsyncBanana
left a comment
There was a problem hiding this comment.
Looks pretty good! Most of my comments are just related to code style/organization.
| type OmitUnion<T, K extends keyof T> = T extends object ? Omit<T, K> : never; | ||
|
|
||
| /** Create a configuration manifest for {@link DatabaseStore}. */ | ||
| export const createConfigurationManifest = < |
There was a problem hiding this comment.
Is this function necessary? It appears that everything could just be rolled into ConfigurationMessage
There was a problem hiding this comment.
From what I can remember this is a function for type-safety reasons. I guess it's possible to do without it as well but that would probably result in a lot more verbose code.
There was a problem hiding this comment.
Why not put the same functionality in the constructor and write each object within the arguments of the constructor?
There was a problem hiding this comment.
That's possible but then you lose the flexibility of being able to use different database tables in a type-safe way.
There was a problem hiding this comment.
Why this folder structure?
There was a problem hiding this comment.
This seems like a common file structure for database repositories to me. 🤔
What structure would you propose we use instead?
| type PlaceholderReplaceHook = (context: PlaceholderReplaceHookContext) => string | null; | ||
|
|
||
| /** Iterate over all placeholder values and replace with the result of the hook (or ignore if `null`). */ | ||
| const placeholderIterateExecute = (text: string, hook: PlaceholderReplaceHook) => { |
There was a problem hiding this comment.
This should be possible to simplify quite a bit by using regex.
There was a problem hiding this comment.
The reason I did this with a lexer is so it can match [name] in a string, but ignore [[name]] (escaped), this is so it can be replaced with the literal [name] text.
I can't immediately figure out a way to do this with regex, perhaps we could use simpler dollar sign placeholders? (e.g: $name, $$name to escape)
goestav
force-pushed
the
feature/configuration-message
branch
from
d42e861 to
8af27e9
Compare
3 participants
This pull request adds a config command to configure the bot.
Closes #24