Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| let key = ''; | ||
| if (metric.name && metric.name.trim()) { | ||
| key = metric.name.trim(); | ||
| } else if (metric.keyword) { |
There was a problem hiding this comment.
[P1] Align metric lookup with sanitized metric keys
The parsing loop now strips punctuation when storing metric data (key = metric.keyword.replace(/[:：]/g, '').trim() and similar for regex). However, the chart still looks up datasets by the raw metric.name || metric.keyword string when building metricElements. For metrics without a name that contain punctuation (e.g. { mode: 'keyword', keyword: 'loss:' }), data are stored under "loss" but later retrieved using "loss:", so the rendered chart contains no series even though values were parsed. Apply the same normalization during lookup (or reuse the metricNames array) so metrics defined only by keyword/regex continue to display.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
npm run lintnpm testhttps://chatgpt.com/codex/tasks/task_e_68b1781683d4832da49c07ddc7fdfaa3