Added Constants Defined by UnifiedPOS 1.15.1#22
Merged
kuniss merged 4 commits intoJavaPOSWorkingGroup:masterfrom Feb 12, 2025
Merged
Added Constants Defined by UnifiedPOS 1.15.1#22kuniss merged 4 commits intoJavaPOSWorkingGroup:masterfrom
kuniss merged 4 commits intoJavaPOSWorkingGroup:masterfrom
Conversation
Constants that have been defined in UPOS 1.15.1 have been added.
Of cause, @deprecated must be written with capital D..
kuniss
requested changes
Feb 7, 2025
Member
kuniss
left a comment
kuniss
left a comment
There was a problem hiding this comment.
Hi @mjpcger,
I checked the changes against UnifiedPOS 1.15.1 Beta1, I found at https://www.omg.org/spec/UPOS/1.15.1/PDF.
All constants spellings are correct. All constant values are meaningful and well defined.
Could you please add javadoc comments for the newly deprecated constants pointing to the new alternatives?
In the meantime, I will try to correct the build system as an outdated GitHub action is used and cause the PR checks to fail.
After that you maybe need to rebase your branch to get the PR updated.
Member
|
I updated the build process. |
Javadoc comments have been added to explain why deprecation has been added to PTR_BCS_EAN128 and SCAN_SDT_EAN128.
kuniss
approved these changes
Feb 7, 2025
kuniss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constants that have been defined in UPOS 1.15.1 have been added.