-
Notifications
You must be signed in to change notification settings - Fork 193
Added Tesera game plugin #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JannisX11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! The game is not released yet, is this intended as an internal tool for the developers behind it?
If so, it would be best to host it internally. There is no need to include it in the public repository if it's just used by a handful of people, it will just mean slower review time.
Plugins can be loaded via the "Load Plugin from URL" option as well if they are hosted on a server and served with the correct media type.
The plugin can still be added to this repository when players can use it to mod the game, if that is planned.
|
Hi! |
|
I see, I will try to find some time to review it this weekend. |
|
Thank you so much |
|
Hey there, sorry this took longer than expected, other things came up and I was traveling. I have some feedback here: The current implementation of custom properties has some issues, for example there is no undo support. There is now a much easier method for implementing properties, including their input field in the properties panel. new Property(CameraElement, 'number', 'fov', {
default: 70,
inputs: {
element_panel: {
input: {label: 'FOV', type: 'number', min: 1, max: 160},
onChange() {
Canvas.updateView({elements: CameraElement.selected, element_aspects: {transform: true}});
}
}
}
});More or less all input types that work in forms are supported, you could probably also add a custom form input type for JSON editing. The plugin adds some custom theming, that seems unrelated to what the plugin is intended to do, and should maybe be an external theme but not part of the plugin. An animation search bar is already included in Blockbench so another one is not required. |
https://store.steampowered.com/app/3258010/Tesera/
https://discord.com/invite/8C72nfZ3WR
https://tesera.io
https://www.youtube.com/@tesera_game/videos