-
Notifications
You must be signed in to change notification settings - Fork 193
Add Check Invalid Rotation Plugin #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Check Invalid Rotation Plugin #785
Conversation
PlanesZwalker
commented
Oct 18, 2025
- Detects non-standard rotations in models before export
- Shows warning dialog with element names and suggested fixes
- Auto-fix functionality for rotations to nearest standard values
- User choice to continue export or cancel to fix first
- Supports multiple rotation fix options
- Compatible with Blockbench 4.12.6+ and Minecraft Bedrock standards
- Automatically detects non-standard rotations in models - Shows warning dialog before export to prevent Minecraft display issues - Auto-fix functionality to correct rotations to nearest standard values - User choice to continue export or cancel to fix rotations first - Compatible with Blockbench 4.12.6+
JannisX11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments on a few issues that I've found.
Apart from that, the issue that I noticed was that no check was performed when saving via Ctrl + S, or File > Save Model.
Btw, in case you didn't see, Minecraft recently lifted the 22.5 degree limit for models, and on bedrock it has never existed in the first place. So I assume this is just intended for legacy versions, any maybe for stylistic consistency if the style requirement is to align with these rotations?
Also, for anything validation-related I can also recomment the Validator API, it can display issues in real time in the UI so could be an addition: https://web.blockbench.net/docs/classes/custom_validator.ValidatorCheck.html
| icon: 'warning', | ||
| version: '1.0.0', | ||
| variant: 'both', | ||
| tags: ['minecraft', 'rotation', 'validation', 'export'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can specify up to 3 tags. Make sure they are formatted for display in UI, in this case they should start with an upper case letter.
| return nonStandardRotations; | ||
| } | ||
|
|
||
| function applyRotationFix(rotation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be unused.
| if (Interface && Interface.updateViewport) { | ||
| Interface.updateViewport(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not exist
| Interface.updateViewport(); | ||
| } | ||
|
|
||
| if (Outliner && Outliner.update) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not exist
| Outliner.update(); | ||
| } | ||
|
|
||
| if (Project && Project.update) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not exist
| } | ||
|
|
||
| setTimeout(() => { | ||
| if (Interface && Interface.updateViewport) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get the idea...
- Remove non-compatible API calls from refreshScene() function - Simplify about.md by removing duplicate version info and repetitive benefits - Streamline changelog.json to avoid feature duplication - Address feedback from @JannisX11 for better maintainability
- Target specific version range (1.8 - 1.18.x) instead of broad 1.8+ - Add disclaimer about Minecraft 1.19+ potentially relaxing restrictions - Update changelog format to match schema (object instead of array) - Reduce tags to 3 maximum (removed 'minecraft' tag) - Improve version specificity and honesty about plugin scope - Update both English and French translations consistently
… fix uninstall cleanup - Removed duplicate save integration methods causing multiple dialogs - Cleaned up code for production (removed comments, optimized formatting) - Fixed uninstall cleanup to properly restore BarItems functions - Individual 'Corriger' buttons now work correctly - Reduced file size by 24% (1257 → 860 lines) - All functionality tested and working
|
Here is my 'cleaned' and improved version ;) |
…alker/blockbench-plugins-Translation-planes-gizmo into rotation-checker-plugin # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.