Open
Conversation
prashant-gurung899
force-pushed
the
make-logo-optional
branch
from
f670227 to
6506f63
Compare
prashant-gurung899
force-pushed
the
make-logo-optional
branch
from
6506f63 to
696b47e
Compare
prashant-gurung899
requested review from
PrajwolAmatya,
anon-pradip,
individual-it and
saw-jan
individual-it
requested changes
Apr 8, 2026
Member
individual-it
left a comment
individual-it
left a comment
There was a problem hiding this comment.
Let's also add some tests
| }) | ||
| } | ||
| function setLogo() { | ||
| const frontMatter = separateFrontmatterAndMarkdown()[1] |
Member
There was a problem hiding this comment.
frontMatter could be passed in as parameter, because in applyTemplateIfNeeded we have already that data.
Signed-off-by: prashant-gurung899 <prasantgrg777@gmail.com>
prashant-gurung899
force-pushed
the
make-logo-optional
branch
from
696b47e to
4ba6be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the logo to be optional.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: