Fix Workflow Timeout? #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `exec 1> >(tee ...)` patterns that create background subprocesses which can hang indefinitely, causing the workflow to timeout at 0.4% CPU. The process substitution with tee was only present in test-target-branch and prepare-notification jobs, not in test-source-branch, which explains why PRs passed (~15min) while main timed out (hours). Root cause: When bash uses `>(tee ...)`, it creates a background process. If the tee doesn't finish writing buffered data before the fd restore, the shell waits indefinitely for the subprocess to exit.
- Simplify test-py-pytest.yml to single-branch test runner (~270 lines vs ~1200) - Create run-branch-test.yml orchestrator with: - Framework detection (extensible for jest, xunit, etc.) - Target branch caching (avoids re-running tests on same SHA) - Concurrency groups (queues concurrent jobs testing same target) - Parallel test execution via pytest-xdist (-n auto) - Fix timeout bug: removed problematic `exec 1> >(tee ...)` process substitution that caused jobs to hang at 0.4% CPU Architecture: - test-py-pytest.yml: Simple, stateless "test this branch" workflow - run-branch-test.yml: Smart orchestrator that calls test workflow twice and compares via regression-test.yml Caching flow: 1. Check cache for target branch + SHA 2. Cache hit: skip test workflow, use cached results 3. Cache miss: run tests, save results to cache 4. Concurrency group ensures only one job populates cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.