Skip to content

Modernisation#24

Merged
JamesRitchie merged 9 commits intomasterfrom
modernisation
Aug 14, 2025
Merged

Modernisation#24
JamesRitchie merged 9 commits intomasterfrom
modernisation

Conversation

@JamesRitchie
Copy link
Copy Markdown
Owner

@JamesRitchie JamesRitchie commented Aug 13, 2025

Having a go at modernising this project as a test case for AI tooling.

Main Changes:

  • Replace setup.py with pyproject.toml.
  • Update the dependencies.
  • Replace Travis CI with Github Actions.
  • Add Ruff linting and formatting.

@JamesRitchie JamesRitchie requested a review from Copilot August 14, 2025 19:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the scikit-rvm project by transitioning from the legacy setup.py configuration to the modern pyproject.toml standard, updating dependencies to current versions, and replacing Travis CI with GitHub Actions. The changes also introduce Ruff for code linting and formatting to improve code quality and consistency.

  • Migration from setup.py to pyproject.toml for modern Python packaging
  • Dependency updates to current versions (numpy>=2.0, scipy>=1.12, scikit-learn>=1.5)
  • CI/CD modernization from Travis CI to GitHub Actions with Ruff linting

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml New modern packaging configuration replacing setup.py
setup.py Removed legacy setup file
.github/workflows/ci.yml New GitHub Actions CI workflow with linting and testing
.travis.yml Removed legacy Travis CI configuration
README.md New Markdown README replacing reStructuredText version
README.rst Removed legacy reStructuredText README
skrvm/init.py Code formatting updates for Ruff compliance
skrvm/rvm.py Code formatting updates and minor bug fixes
tests/test_rvm.py Extensive code formatting updates for Ruff compliance
tests/performance.py Minor formatting cleanup
Comments suppressed due to low confidence (2)

skrvm/rvm.py:1

  • The scientific notation format is incorrect. 'e00' should be 'e+00' to properly represent 1.0.
"""Relevance Vector Machine classes for regression and classification."""

skrvm/rvm.py:1

  • The scientific notation format is incorrect. 'e00' should be 'e+00' to properly represent the number properly.
"""Relevance Vector Machine classes for regression and classification."""

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@JamesRitchie JamesRitchie merged commit 69fb1f8 into master Aug 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants