Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the scikit-rvm project by transitioning from the legacy setup.py configuration to the modern pyproject.toml standard, updating dependencies to current versions, and replacing Travis CI with GitHub Actions. The changes also introduce Ruff for code linting and formatting to improve code quality and consistency.
- Migration from setup.py to pyproject.toml for modern Python packaging
- Dependency updates to current versions (numpy>=2.0, scipy>=1.12, scikit-learn>=1.5)
- CI/CD modernization from Travis CI to GitHub Actions with Ruff linting
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | New modern packaging configuration replacing setup.py |
| setup.py | Removed legacy setup file |
| .github/workflows/ci.yml | New GitHub Actions CI workflow with linting and testing |
| .travis.yml | Removed legacy Travis CI configuration |
| README.md | New Markdown README replacing reStructuredText version |
| README.rst | Removed legacy reStructuredText README |
| skrvm/init.py | Code formatting updates for Ruff compliance |
| skrvm/rvm.py | Code formatting updates and minor bug fixes |
| tests/test_rvm.py | Extensive code formatting updates for Ruff compliance |
| tests/performance.py | Minor formatting cleanup |
Comments suppressed due to low confidence (2)
skrvm/rvm.py:1
- The scientific notation format is incorrect. 'e00' should be 'e+00' to properly represent 1.0.
"""Relevance Vector Machine classes for regression and classification."""
skrvm/rvm.py:1
- The scientific notation format is incorrect. 'e00' should be 'e+00' to properly represent the number properly.
"""Relevance Vector Machine classes for regression and classification."""
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a go at modernising this project as a test case for AI tooling.
Main Changes: