-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/pds registration #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added BGS Integration Plan document. - Updated to include and . - Updated to find donors by DID + Identifier. - Updated to auto-provision or link Specimen Donors for Atmosphere samples.
- Modified update method to include more fields. - Added to for efficient sequence file cleanup. - Implemented in to handle full replacement of sequencing data. - Refactored to perform an upsert (update or insert) based on , including Specimen Donor and full sequence data replacement.
- Added method to for direct deletion by ID. - Added to and for cascading deletions. - Implemented in to orchestrate a hard delete of a biosample and all its dependent data. - Added to to provide service-level deletion by accession. - Exposed a endpoint in for BGS server initiated deletion.
- Updated endpoint in to require parameter. - Updated to verify that the biosample belongs to the provided before deletion. - Prevents ID collision and ensures ownership verification for BGS-initiated deletions.
- Fixed syntax errors in (mismatched braces/parentheses). - Added missing import in . - Verified successful compilation with [info] welcome to sbt 1.10.11 (Red Hat, Inc. Java 21.0.9) [info] loading global plugins from /home/jkane/.sbt/1.0/plugins [info] loading settings for project decodingus-build from plugins.sbt... [info] loading project definition from /home/jkane/devel/scala3/decodingus/project [info] loading settings for project root from build.sbt... [info] __ __ [info] \ \ ____ / /____ _ __ __ [info] \ \ / __ \ / // __ `// / / / [info] / / / /_/ // // /_/ // /_/ / [info] /_/ / .___//_/ \__,_/ \__, / [info] /_/ /____/ [info] [info] Version 3.0.9 running Java 21.0.9 [info] [info] Play is run entirely by the community. Please consider contributing and/or donating: [info] https://www.playframework.com/sponsors [info] [info] Executing in batch mode. For better performance use sbt's shell [success] Total time: 0 s, completed Dec 5, 2025, 8:47:48 AM.
…l biosample types
… full flow diagram
- Add `specimenDonorId` field and foreign key in `citizen_biosample` table. - Enable resolving or creating Specimen Donors during biosample creation and updates. - Update `CitizenBiosampleService` to handle Specimen Donor associations.
- Add `specimenDonorId` field and foreign key in `citizen_biosample` table. - Enable resolving or creating Specimen Donors during biosample creation and updates. - Update `CitizenBiosampleService` to handle Specimen Donor associations.
…to new event-driven CitizenBiosampleEventHandler. Introduce unified FirehoseEvent abstraction for Create, Update, and Delete operations.
…ervice, and PDSRegistrationService - Introduce unit tests for `CitizenBiosampleEventHandler`, covering Create, Update, Delete operations, and edge cases like conflicts and not found scenarios. - Add service-level tests for `CitizenBiosampleService`, handling delegation to the event handler and proper result translations. - Implement tests for `PDSRegistrationService`, including new registration, conflict detection, and PDS retrieval by DID/handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.